summaryrefslogtreecommitdiff
path: root/compiler/optimizing
diff options
context:
space:
mode:
author Santiago Aboy Solanes <solanes@google.com> 2024-03-08 15:48:44 +0000
committer Santiago Aboy Solanes <solanes@google.com> 2024-03-12 15:52:28 +0000
commit5937cdeeef4639e523ae3cfde3bfce3ccb252921 (patch)
tree8c87fc2983ee01ae68fa79be1afb6cd3886d3053 /compiler/optimizing
parent68f3ec8001c46f00f82043d7100c04dee4449c48 (diff)
Remove default cases when all cases are defined
Bug: 328756212 Test: art/test/testrunner/testrunner.py --host --64 --optimizing -b Test: m test-art-host-gtest Change-Id: I9584e1b93e49265b84a9e45c8b283ebaf8ad3eb2
Diffstat (limited to 'compiler/optimizing')
-rw-r--r--compiler/optimizing/common_arm64.h2
-rw-r--r--compiler/optimizing/graph_visualizer.cc3
-rw-r--r--compiler/optimizing/inliner.cc3
-rw-r--r--compiler/optimizing/nodes.cc9
-rw-r--r--compiler/optimizing/superblock_cloner.cc3
5 files changed, 0 insertions, 20 deletions
diff --git a/compiler/optimizing/common_arm64.h b/compiler/optimizing/common_arm64.h
index e2ef8d52f2..8b64b2e2e8 100644
--- a/compiler/optimizing/common_arm64.h
+++ b/compiler/optimizing/common_arm64.h
@@ -349,7 +349,6 @@ inline vixl::aarch64::Shift ShiftFromOpKind(HDataProcWithShifterOp::OpKind op_ki
default:
LOG(FATAL) << "Unexpected op kind " << op_kind;
UNREACHABLE();
- return vixl::aarch64::NO_SHIFT;
}
}
@@ -364,7 +363,6 @@ inline vixl::aarch64::Extend ExtendFromOpKind(HDataProcWithShifterOp::OpKind op_
default:
LOG(FATAL) << "Unexpected op kind " << op_kind;
UNREACHABLE();
- return vixl::aarch64::NO_EXTEND;
}
}
diff --git a/compiler/optimizing/graph_visualizer.cc b/compiler/optimizing/graph_visualizer.cc
index 6696c1ef17..1e4f71f9a2 100644
--- a/compiler/optimizing/graph_visualizer.cc
+++ b/compiler/optimizing/graph_visualizer.cc
@@ -109,9 +109,6 @@ std::ostream& operator<<(std::ostream& os, const StringList& list) {
switch (list.format_) {
case StringList::kArrayBrackets: return os << "[" << list.sstream_.str() << "]";
case StringList::kSetBrackets: return os << "{" << list.sstream_.str() << "}";
- default:
- LOG(FATAL) << "Invalid StringList format";
- UNREACHABLE();
}
}
diff --git a/compiler/optimizing/inliner.cc b/compiler/optimizing/inliner.cc
index 5917f8447e..0fd3eeab2e 100644
--- a/compiler/optimizing/inliner.cc
+++ b/compiler/optimizing/inliner.cc
@@ -1807,9 +1807,6 @@ bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
number_of_instructions = number_of_iputs + (needs_constructor_barrier ? 1u : 0u);
break;
}
- default:
- LOG(FATAL) << "UNREACHABLE";
- UNREACHABLE();
}
if (number_of_instructions != 0u) {
total_number_of_instructions_ += number_of_instructions;
diff --git a/compiler/optimizing/nodes.cc b/compiler/optimizing/nodes.cc
index c87c78815b..ba268560e8 100644
--- a/compiler/optimizing/nodes.cc
+++ b/compiler/optimizing/nodes.cc
@@ -1885,9 +1885,6 @@ std::ostream& operator<<(std::ostream& os, ComparisonBias rhs) {
return os << "gt";
case ComparisonBias::kLtBias:
return os << "lt";
- default:
- LOG(FATAL) << "Unknown ComparisonBias: " << static_cast<int>(rhs);
- UNREACHABLE();
}
}
@@ -3244,9 +3241,6 @@ std::ostream& operator<<(std::ostream& os, HInvokeStaticOrDirect::ClinitCheckReq
return os << "implicit";
case HInvokeStaticOrDirect::ClinitCheckRequirement::kNone:
return os << "none";
- default:
- LOG(FATAL) << "Unknown ClinitCheckRequirement: " << static_cast<int>(rhs);
- UNREACHABLE();
}
}
@@ -3426,9 +3420,6 @@ std::ostream& operator<<(std::ostream& os, TypeCheckKind rhs) {
return os << "array_check";
case TypeCheckKind::kBitstringCheck:
return os << "bitstring_check";
- default:
- LOG(FATAL) << "Unknown TypeCheckKind: " << static_cast<int>(rhs);
- UNREACHABLE();
}
}
diff --git a/compiler/optimizing/superblock_cloner.cc b/compiler/optimizing/superblock_cloner.cc
index 7c0097c6f6..0a7b95a1fb 100644
--- a/compiler/optimizing/superblock_cloner.cc
+++ b/compiler/optimizing/superblock_cloner.cc
@@ -1171,9 +1171,6 @@ HBasicBlock* LoopClonerHelper::DoLoopTransformationImpl(TransformationKind trans
case TransformationKind::kVersioning:
oss << "versioning";
break;
- default:
- LOG(FATAL) << "Unreachable";
- UNREACHABLE();
}
oss << " was applied to the loop <" << loop_header->GetBlockId() << ">.";
LOG(INFO) << oss.str();