summaryrefslogtreecommitdiff
path: root/compiler/optimizing/sharpening.cc
diff options
context:
space:
mode:
author Santiago Aboy Solanes <solanes@google.com> 2021-12-02 11:50:03 +0000
committer Treehugger Robot <treehugger-gerrit@google.com> 2022-01-13 00:26:45 +0000
commit32b8c8f33ad68982357c1fa3d0f132d06b070ab5 (patch)
tree578504a572bfe61ddc22cfb6ce5013bcae28882e /compiler/optimizing/sharpening.cc
parent8515f7fcf0fca795e5408ab691846b23ba608bda (diff)
Expand sharpening's ComputeLoadClassKind to cover cross-dex cases
We can handle some extra cross-dex cases in order to expand the support. Bug: 154012332 Test: ART tests Change-Id: Ic3220d809086b4b3007bf5b6d63789ffb1b91fb9
Diffstat (limited to 'compiler/optimizing/sharpening.cc')
-rw-r--r--compiler/optimizing/sharpening.cc15
1 files changed, 9 insertions, 6 deletions
diff --git a/compiler/optimizing/sharpening.cc b/compiler/optimizing/sharpening.cc
index 1fd76f7029..cb9edc0127 100644
--- a/compiler/optimizing/sharpening.cc
+++ b/compiler/optimizing/sharpening.cc
@@ -275,15 +275,18 @@ HLoadClass::LoadKind HSharpening::ComputeLoadClassKind(
}
HLoadClass::LoadKind load_kind = codegen->GetSupportedLoadClassKind(desired_load_kind);
+ // If we cannot reference this class due to .bss requirements, we're forced to bail.
if (!IsSameDexFile(load_class->GetDexFile(), *dex_compilation_unit.GetDexFile())) {
- if (load_kind == HLoadClass::LoadKind::kRuntimeCall ||
- load_kind == HLoadClass::LoadKind::kBssEntry ||
+ if (load_kind == HLoadClass::LoadKind::kRuntimeCall) {
+ return HLoadClass::LoadKind::kInvalid;
+ }
+
+ if (load_kind == HLoadClass::LoadKind::kBssEntry ||
load_kind == HLoadClass::LoadKind::kBssEntryPublic ||
load_kind == HLoadClass::LoadKind::kBssEntryPackage) {
- // We actually cannot reference this class, we're forced to bail.
- // We cannot reference this class with Bss, as the entrypoint will lookup the class
- // in the caller's dex file, but that dex file does not reference the class.
- return HLoadClass::LoadKind::kInvalid;
+ if (!codegen->GetCompilerOptions().WithinOatFile(&load_class->GetDexFile())) {
+ return HLoadClass::LoadKind::kInvalid;
+ }
}
}
return load_kind;