diff options
| author | 2024-01-12 18:40:49 +0000 | |
|---|---|---|
| committer | 2024-01-15 17:20:00 +0000 | |
| commit | f0a31e107973f3bde7dd54cd7610082b104922db (patch) | |
| tree | bca251e08f48f03d3ff127ea1a00765a66a0bc8d /compiler/optimizing/optimizing_compiler.cc | |
| parent | de9364ce93135d021b1a26a3f2d0b611dd0d8527 (diff) | |
Revert "Restrict the use of ConstantFolding's VisitIf"
This reverts commit 5eb1fd0dae3832ceee2102613bb08c291daca6f3.
Reason for revert: In aosp/2903248 we implemented a faster way of
doing `ReplaceUsesDominatedBy` which is used by `VisitIf`. The impact
of `VisitIf` is now small enough that running VisitIf in all passes
is faster that the previous implementation running some of the time.
This CLs re-enables the optimization in all constant folding passes
because:
A) Lets this optimization (and others that can use the result) kick in
earlier
B) Run it for callee graphs in the inliner (which has been disabled as
of CL aosp/2543831)
C) Consistency of the ConstantFolding pass, which helps to have a
simpler mental model
Bug: 278626992
Test: art/test/testrunner/testrunner.py --host --64 --optimizing -b
Test: Locally compiled GMS and compared time to compile
Change-Id: I5dc5f591557c8de0bc4d23dbfd0b91b5b7e56ab5
Diffstat (limited to 'compiler/optimizing/optimizing_compiler.cc')
| -rw-r--r-- | compiler/optimizing/optimizing_compiler.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/optimizing/optimizing_compiler.cc b/compiler/optimizing/optimizing_compiler.cc index d458462226..8909a59ddf 100644 --- a/compiler/optimizing/optimizing_compiler.cc +++ b/compiler/optimizing/optimizing_compiler.cc @@ -666,7 +666,7 @@ void OptimizingCompiler::RunOptimizations(HGraph* graph, OptDef(OptimizationPass::kGlobalValueNumbering), // Simplification (TODO: only if GVN occurred). OptDef(OptimizationPass::kSelectGenerator), - OptDef(OptimizationPass::kAggressiveConstantFolding, + OptDef(OptimizationPass::kConstantFolding, "constant_folding$after_gvn"), OptDef(OptimizationPass::kInstructionSimplifier, "instruction_simplifier$after_gvn"), |