Optimizing: Rename `As##type` to `As##type##OrNull`.

The null type check in the current implementation of
`HInstruction::As##type()` often cannot be optimized away
by clang++. It is therefore beneficial to have two functions
    HInstruction::As##type()
    HInstruction::As##type##OrNull()
where the first function never returns null but the second
one can return null. The additional text "OrNull" shall also
flag the possibility of yielding null to the developer which
may help avoid bugs similar to what we have seen previously.

This requires renaming the existing function that can return
null and introducing new function that cannot. However,
defining the new function `HInstruction::As##type()` in the
same change as renaming the old one would risk introducing
bugs by missing a rename. Therefore we simply rename the old
function here and the new function shall be introduced in a
separate change with all behavioral changes being explicit.

Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing
Test: buildbot-build.sh --target
Bug: 181943478
Change-Id: I4defd85038e28fe3506903ba3f33f723682b3298

1 files changed, 4 insertions, 2 deletions

diff --git a/compiler/optimizing/nodes_shared.h b/compiler/optimizing/nodes_shared.h
index 27e610328f..b91cc3e5fd 100644
--- a/compiler/optimizing/nodes_shared.h
+++ b/compiler/optimizing/nodes_shared.h
@@ -47,7 +47,8 @@ class HMultiplyAccumulate final : public HExpression<3> {
 
   bool CanBeMoved() const override { return true; }
   bool InstructionDataEquals(const HInstruction* other) const override {
-    return op_kind_ == other->AsMultiplyAccumulate()->op_kind_;
+    // TODO: Remove "OrNull".
+    return op_kind_ == other->AsMultiplyAccumulateOrNull()->op_kind_;
   }
 
   InstructionKind GetOpKind() const { return op_kind_; }
@@ -215,7 +216,8 @@ class HDataProcWithShifterOp final : public HExpression<2> {
   bool IsClonable() const override { return true; }
   bool CanBeMoved() const override { return true; }
   bool InstructionDataEquals(const HInstruction* other_instr) const override {
-    const HDataProcWithShifterOp* other = other_instr->AsDataProcWithShifterOp();
+    // TODO: Remove "OrNull".
+    const HDataProcWithShifterOp* other = other_instr->AsDataProcWithShifterOpOrNull();
     return instr_kind_ == other->instr_kind_ &&
         op_kind_ == other->op_kind_ &&
         shift_amount_ == other->shift_amount_;