diff options
author | 2022-08-09 11:54:19 +0000 | |
---|---|---|
committer | 2022-08-09 13:21:11 +0000 | |
commit | fa1034c563b44c4f557814c50e2678e14dcd1d13 (patch) | |
tree | 6353ca19b0f193183310ad7cd77c199bce64eb18 /compiler/optimizing/nodes.h | |
parent | 6981ef9238ce2d4ea3f7a86d3faf5d720c8c4641 (diff) |
Revert "Propagating values from if clauses to its successors"
This reverts commit c6b816ceb2b35300c937ef2e7d008598b6afba21.
Reason for revert: Broke libcore test https://ci.chromium.org/ui/p/art/builders/ci/angler-armv7-ndebug/3179/overview
Change-Id: I4f238bd20cc485e49078104e0225c373cac23415
Diffstat (limited to 'compiler/optimizing/nodes.h')
-rw-r--r-- | compiler/optimizing/nodes.h | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/compiler/optimizing/nodes.h b/compiler/optimizing/nodes.h index 103d318710..39cb9275fb 100644 --- a/compiler/optimizing/nodes.h +++ b/compiler/optimizing/nodes.h @@ -2444,12 +2444,9 @@ class HInstruction : public ArenaObject<kArenaAllocInstruction> { return IsRemovable() && !HasUses(); } - // Does this instruction dominate `other_instruction`? - // Aborts if this instruction and `other_instruction` are different phis. - bool Dominates(HInstruction* other_instruction) const; - - // Same but with `strictly dominates` i.e. returns false if this instruction and - // `other_instruction` are the same. + // Does this instruction strictly dominate `other_instruction`? + // Returns false if this instruction and `other_instruction` are the same. + // Aborts if this instruction and `other_instruction` are both phis. bool StrictlyDominates(HInstruction* other_instruction) const; int GetId() const { return id_; } @@ -2514,9 +2511,7 @@ class HInstruction : public ArenaObject<kArenaAllocInstruction> { void SetLocations(LocationSummary* locations) { locations_ = locations; } void ReplaceWith(HInstruction* instruction); - void ReplaceUsesDominatedBy(HInstruction* dominator, - HInstruction* replacement, - bool strictly_dominated = true); + void ReplaceUsesDominatedBy(HInstruction* dominator, HInstruction* replacement); void ReplaceEnvUsesDominatedBy(HInstruction* dominator, HInstruction* replacement); void ReplaceInput(HInstruction* replacement, size_t index); |