diff options
| author | 2017-04-18 09:37:23 -0700 | |
|---|---|---|
| committer | 2017-05-18 14:14:13 +0000 | |
| commit | 79d8fa7c52c1810d4618c9bd1d43994be5abb53d (patch) | |
| tree | 411a76dec2adf4139328d5e607b498b72c9aa2af /compiler/optimizing/nodes.h | |
| parent | acac09dad3d5aa3922e6cdf54ff2e4fa6f176484 (diff) | |
optimizing: Build HConstructorFence for HNewArray/HNewInstance nodes
Also fixes:
* LSE, code_sinking to keep optimizing new-instance if it did so before
* Various tests to expect constructor fences after new-instance
Sidenote: new-instance String does not get a ConstructorFence; the
special StringFactory calls are assumed to be self-fencing.
Metric changes on go/lem:
* CodeSize -0.262% in ART-Compile (ARMv8)
* RunTime -0.747% for all (linux-armv8)
(No changes expected to x86, constructor fences are no-op).
The RunTime regression is temporary until art_quick_alloc_* entrypoints have their
DMBs removed in a follow up CL.
Test: art/test.py
Bug: 36656456
Change-Id: I6a936a6e51c623e1c6b5b22eee5c3c72bebbed35
Diffstat (limited to 'compiler/optimizing/nodes.h')
| -rw-r--r-- | compiler/optimizing/nodes.h | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/compiler/optimizing/nodes.h b/compiler/optimizing/nodes.h index e40361eb5d..72521fd3a9 100644 --- a/compiler/optimizing/nodes.h +++ b/compiler/optimizing/nodes.h @@ -6650,6 +6650,14 @@ class HConstructorFence FINAL : public HVariableInputSizeInstruction { // still considered live. static void RemoveConstructorFences(HInstruction* instruction); + // Check if this constructor fence is protecting + // an HNewInstance or HNewArray that is also the immediate + // predecessor of `this`. + // + // Returns the associated HNewArray or HNewInstance, + // or null otherwise. + HInstruction* GetAssociatedAllocation(); + DECLARE_INSTRUCTION(ConstructorFence); private: |