diff options
| author | 2015-04-03 16:02:44 +0100 | |
|---|---|---|
| committer | 2015-04-15 12:51:49 +0100 | |
| commit | 66d126ea06ce3f507d86ca5f0d1f752170ac9be1 (patch) | |
| tree | 8e247db17ef085b55725b21c64d292414fd00b32 /compiler/optimizing/nodes.h | |
| parent | 9bb3e8e10d7d9230a323511094a9e260062a1473 (diff) | |
ART: Implement HBooleanNot instruction
Optimizations simplifying operations on boolean values (boolean
simplifier, instruction simplifier) can benefit from having a special
HInstruction for negating booleans in order to perform more transforms
and produce faster machine code.
This patch implements HBooleanNot as 'x xor 1', assuming that booleans
are 1-bit integers and allowing for a single-instruction negation on
all supported platforms.
Change-Id: I33a2649c1821255b18a86ca68ed16416063c739f
Diffstat (limited to 'compiler/optimizing/nodes.h')
| -rw-r--r-- | compiler/optimizing/nodes.h | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/compiler/optimizing/nodes.h b/compiler/optimizing/nodes.h index 5f50494482..e2eafe5565 100644 --- a/compiler/optimizing/nodes.h +++ b/compiler/optimizing/nodes.h @@ -676,6 +676,7 @@ class HLoopInformationOutwardIterator : public ValueObject { M(ArrayGet, Instruction) \ M(ArrayLength, Instruction) \ M(ArraySet, Instruction) \ + M(BooleanNot, UnaryOperation) \ M(BoundsCheck, Instruction) \ M(BoundType, Instruction) \ M(CheckCast, Instruction) \ @@ -2643,6 +2644,33 @@ class HNot : public HUnaryOperation { DISALLOW_COPY_AND_ASSIGN(HNot); }; +class HBooleanNot : public HUnaryOperation { + public: + explicit HBooleanNot(HInstruction* input) + : HUnaryOperation(Primitive::Type::kPrimBoolean, input) {} + + bool CanBeMoved() const OVERRIDE { return true; } + bool InstructionDataEquals(HInstruction* other) const OVERRIDE { + UNUSED(other); + return true; + } + + int32_t Evaluate(int32_t x) const OVERRIDE { + DCHECK(IsUint<1>(x)); + return !x; + } + + int64_t Evaluate(int64_t x ATTRIBUTE_UNUSED) const OVERRIDE { + LOG(FATAL) << DebugName() << " cannot be used with 64-bit values"; + UNREACHABLE(); + } + + DECLARE_INSTRUCTION(BooleanNot); + + private: + DISALLOW_COPY_AND_ASSIGN(HBooleanNot); +}; + class HTypeConversion : public HExpression<1> { public: // Instantiate a type conversion of `input` to `result_type`. |