diff options
| author | 2020-07-23 12:34:56 +0000 | |
|---|---|---|
| committer | 2020-07-24 10:11:54 +0000 | |
| commit | a0130e8d2842a9a82e4fd4e811ee699272eb2e0b (patch) | |
| tree | 1468e015b7c4b001e40d847cf1448311706516e7 /compiler/optimizing/nodes.cc | |
| parent | 75c8b635178d0c59691c2bc22f3bd1101d5516b5 (diff) | |
Prepare compiler for adding VarHandle support.
This commit prepares the ground for adding VarHandle support
in the compiler. The intrinsic locations builder and code
generator are now triggered for HInvokePolymorphic nodes.
VarHandle and MethodHandle intrinsics are marked as unimplemented
rather than unreachable.
Since the Varhandle intrinsics are not implemented yet, the
functionality is not changed (i.e. the intrinsics are evaluated
at runtime and not compiled). I manually tested that the intrinsic
Visit* methods are triggered for the VarHandle methods.
Bug: b/65872996
Test: art/test.py --host -r -t 713-varhandle-invokers
Test: art/test.py --host --all-compiler -r
Change-Id: I3333728c5f16d8dc4f92ceae2738ed59b3e31e6a
Diffstat (limited to 'compiler/optimizing/nodes.cc')
| -rw-r--r-- | compiler/optimizing/nodes.cc | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/compiler/optimizing/nodes.cc b/compiler/optimizing/nodes.cc index 64e62fd01e..22e165767d 100644 --- a/compiler/optimizing/nodes.cc +++ b/compiler/optimizing/nodes.cc @@ -3159,11 +3159,7 @@ static inline IntrinsicExceptions GetExceptionsIntrinsic(Intrinsics i) { } void HInvoke::SetResolvedMethod(ArtMethod* method) { - // TODO: b/65872996 The intent is that polymorphic signature methods should - // be compiler intrinsics. At present, they are only interpreter intrinsics. - if (method != nullptr && - method->IsIntrinsic() && - !method->IsPolymorphicSignature()) { + if (method != nullptr && method->IsIntrinsic()) { Intrinsics intrinsic = static_cast<Intrinsics>(method->GetIntrinsic()); SetIntrinsic(intrinsic, NeedsEnvironmentOrCacheIntrinsic(intrinsic), |