diff options
author | 2024-01-24 17:42:08 +0000 | |
---|---|---|
committer | 2024-01-24 22:21:16 +0000 | |
commit | 1ba3516e8c3e2b86c73084893dd297f468469181 (patch) | |
tree | 4b0c99a53fff26f6fe9489049f1830c54af08b86 /compiler/optimizing/intrinsics_arm64.cc | |
parent | 6b866347f77e264143cf3fbc677c3da0ef9acd5b (diff) |
Revert^6 "Disable write-barrier elimination pass"
This reverts commit 1be176f5a78750e2f0e32470f8c83e3d1643954d.
Reason for revert: Potential cause of build breakage for cf_riscv64_wear-trunk_staging-userdebug build 11353124
Change-Id: I5db1c9fba1edd4ab1eef30e2b547bb9649af5c10
Diffstat (limited to 'compiler/optimizing/intrinsics_arm64.cc')
-rw-r--r-- | compiler/optimizing/intrinsics_arm64.cc | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/compiler/optimizing/intrinsics_arm64.cc b/compiler/optimizing/intrinsics_arm64.cc index 2ae44cd4b0..98e526196c 100644 --- a/compiler/optimizing/intrinsics_arm64.cc +++ b/compiler/optimizing/intrinsics_arm64.cc @@ -986,7 +986,7 @@ static void GenUnsafePut(HInvoke* invoke, if (type == DataType::Type::kReference) { bool value_can_be_null = true; // TODO: Worth finding out this information? - codegen->MaybeMarkGCCard(base, value, value_can_be_null); + codegen->MarkGCCard(base, value, value_can_be_null); } } @@ -1457,7 +1457,7 @@ static void GenUnsafeCas(HInvoke* invoke, DataType::Type type, CodeGeneratorARM6 if (type == DataType::Type::kReference) { // Mark card for object assuming new value is stored. bool new_value_can_be_null = true; // TODO: Worth finding out this information? - codegen->MaybeMarkGCCard(base, new_value, new_value_can_be_null); + codegen->MarkGCCard(base, new_value, new_value_can_be_null); } UseScratchRegisterScope temps(masm); @@ -1733,7 +1733,7 @@ static void GenUnsafeGetAndUpdate(HInvoke* invoke, DCHECK(get_and_update_op == GetAndUpdateOp::kSet); // Mark card for object as a new value shall be stored. bool new_value_can_be_null = true; // TODO: Worth finding out this information? - codegen->MaybeMarkGCCard(base, /*value=*/arg, new_value_can_be_null); + codegen->MarkGCCard(base, /*value=*/ arg, new_value_can_be_null); } __ Add(tmp_ptr, base.X(), Operand(offset)); @@ -3394,7 +3394,7 @@ void IntrinsicCodeGeneratorARM64::VisitSystemArrayCopy(HInvoke* invoke) { } // We only need one card marking on the destination array. - codegen_->MarkGCCard(dest.W()); + codegen_->MarkGCCard(dest.W(), Register(), /* emit_null_check= */ false); __ Bind(&skip_copy_and_write_barrier); } @@ -4977,7 +4977,7 @@ static void GenerateVarHandleSet(HInvoke* invoke, } if (CodeGenerator::StoreNeedsWriteBarrier(value_type, invoke->InputAt(value_index))) { - codegen->MaybeMarkGCCard(target.object, Register(value), /* emit_null_check= */ true); + codegen->MarkGCCard(target.object, Register(value), /* emit_null_check= */ true); } if (slow_path != nullptr) { @@ -5141,7 +5141,7 @@ static void GenerateVarHandleCompareAndSetOrExchange(HInvoke* invoke, if (CodeGenerator::StoreNeedsWriteBarrier(value_type, invoke->InputAt(new_value_index))) { // Mark card for object assuming new value is stored. bool new_value_can_be_null = true; // TODO: Worth finding out this information? - codegen->MaybeMarkGCCard(target.object, new_value.W(), new_value_can_be_null); + codegen->MarkGCCard(target.object, new_value.W(), new_value_can_be_null); } // Reuse the `offset` temporary for the pointer to the target location, @@ -5445,7 +5445,7 @@ static void GenerateVarHandleGetAndUpdate(HInvoke* invoke, DCHECK(get_and_update_op == GetAndUpdateOp::kSet); // Mark card for object, the new value shall be stored. bool new_value_can_be_null = true; // TODO: Worth finding out this information? - codegen->MaybeMarkGCCard(target.object, arg.W(), new_value_can_be_null); + codegen->MarkGCCard(target.object, arg.W(), new_value_can_be_null); } // Reuse the `target.offset` temporary for the pointer to the target location, |