summaryrefslogtreecommitdiff
path: root/compiler/optimizing/intrinsics.h
diff options
context:
space:
mode:
author George Burgess IV <gbiv@google.com> 2021-07-19 18:21:53 +0000
committer George Burgess IV <gbiv@google.com> 2021-07-20 16:39:15 +0000
commite501434b98c740969607e400678a43a8f3c79942 (patch)
tree05c85246b6e125f49cdb97a46119adfaf6a0a339 /compiler/optimizing/intrinsics.h
parent81c76d8dac3f4c4d50cad21a0b94a155908bc7d1 (diff)
dt_fd_forward: fix uses of uninit values
`NetworkToHost(x)` where `x` is uninitialized (or isn't fully written with bytes) angers our static analyzer, and may be easy to accidentally use going forward. If we rephrase `HandleResult` to instead take a callable type that produces a T, we can sidestep all of this. Caught by the static analyzer: > art/dt_fd_forward/dt_fd_forward.cc:554:30: warning: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage] > art/dt_fd_forward/dt_fd_forward.cc:563:30: warning: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage] > art/dt_fd_forward/dt_fd_forward.cc:572:30: warning: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage] Bug: None Test: TreeHugger, `WITH_TIDY=1 CLANG_ANALYZER_CHECKS=1 mma` Change-Id: Id759bd36085bdd34399b64b08363b4682746fdfa
Diffstat (limited to 'compiler/optimizing/intrinsics.h')
0 files changed, 0 insertions, 0 deletions