diff options
author | 2020-03-25 17:03:14 +0000 | |
---|---|---|
committer | 2020-03-26 10:16:18 +0000 | |
commit | aacb4b84078eacbee31f168676750ca73514217e (patch) | |
tree | 052188480502b4074d9d1c90f3bcc3c0a4004104 /compiler/optimizing/instruction_builder.cc | |
parent | 584e5996608a263feb8fd4241b78a83501a46868 (diff) |
Fix logical error in a gtest that caused intermittent failures.
The purpose of DexLayoutTest.DexFileLayoutFixedPoint test is to check
that dexlayout transformation is idempotent: repetitive applications of
dexlayout produce the same result. The tests runs dexlayout twice and
ensures that dexlayout(dexlayout(file)) = dexlayout(file).
However, the test erroneously discarded the result of the first run
and ended up checking dexlayout(file) = file, which happens to be true
most of the time (so the error went unnoticed for a while).
Test: m test-art-host-gtest-dexlayout_test64
Test: m test-art-host-gtest-dexlayout_test32
Change-Id: I07633a0e7678e640b144295470d285d1d89a9d8a
Diffstat (limited to 'compiler/optimizing/instruction_builder.cc')
0 files changed, 0 insertions, 0 deletions