summaryrefslogtreecommitdiff
path: root/compiler/optimizing/instruction_builder.cc
diff options
context:
space:
mode:
author Cole Faust <colefaust@google.com> 2023-04-19 13:36:08 -0700
committer Cole Faust <colefaust@google.com> 2023-04-22 01:18:03 +0000
commit2322aa5a791a9d25abfc56954ffa677c9c580455 (patch)
treebd7ce21d4e4f2e08860c398bf41a32eb6505ee0d /compiler/optimizing/instruction_builder.cc
parentb80a870c0da49b4e164344b6254ddddb20d99fbc (diff)
Remove art defaults modules types
libart_cc_defaults and libart_static_cc_defaults can be simply removed, because they only have effects if their target use the `codegen` property, which they don't. art_debug_defaults can be replaced with a soong config variable-based module type. The other art module types will probably be kept and converted to bazel macros, but the defaults ones are tricker because we run the defaults mutator before bp2build is run. Bp2build can convert the art module types to bazel, but it sees the cc modules that the art modules make after the art modules have affected their properties. So they essentially "bake in" the art module changes into the generated BUILD file. This causes the generated BUILD files to be different depending on which product was lunched. We don't want those differences because it means we can't check in the generated BUILD files. Bug: 247785938 Test: Verified ninja files don't change before/after this cl. (they actually do, but only in comments and the module types that are passed to the licensing generator) Also tested a build with ART_DEBUG_OPT_FLAG=-O0 Change-Id: I7a28eb6455f05b3b846586270b32c6b8e1be200c
Diffstat (limited to 'compiler/optimizing/instruction_builder.cc')
0 files changed, 0 insertions, 0 deletions