diff options
author | 2022-03-07 11:45:47 +0000 | |
---|---|---|
committer | 2022-03-07 11:45:47 +0000 | |
commit | 3d004a52434a7dbbc73bb477b7475cad27af6e94 (patch) | |
tree | bb79e448197020c4d9126f550e69b0eb51afe49a /compiler/optimizing/inliner.cc | |
parent | 01ad6eb32f46860a14c24dd5429a6f7afa09f013 (diff) | |
parent | b740438513307629491c575dbf895bbbf215f77c (diff) |
Revert^2 "Add bss support for inlining BCP DexFiles for single image" am: b740438513
Original change: https://android-review.googlesource.com/c/platform/art/+/1968661
Change-Id: Ie0079c06b66f788c8b1ce115742615061dffbfd3
Diffstat (limited to 'compiler/optimizing/inliner.cc')
-rw-r--r-- | compiler/optimizing/inliner.cc | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/compiler/optimizing/inliner.cc b/compiler/optimizing/inliner.cc index 1df313d7fc..c6301c589e 100644 --- a/compiler/optimizing/inliner.cc +++ b/compiler/optimizing/inliner.cc @@ -1740,11 +1740,12 @@ static bool CanEncodeInlinedMethodInStackMap(const DexFile& outer_dex_file, // Inline across dexfiles if the callee's DexFile is: // 1) in the bootclasspath, or if (callee->GetDeclaringClass()->GetClassLoader() == nullptr) { - // There are cases in which the BCP DexFiles are within the OatFile as far as the compiler - // options are concerned, but they have their own OatWriter (and therefore not in the same - // OatFile). Then, we request the BSS check for all BCP DexFiles. - // TODO(solanes): Add .bss support for BCP. - *out_needs_bss_check = true; + // In multi-image, each BCP DexFile has their own OatWriter. Since they don't cooperate with + // each other, we request the BSS check for them. + // TODO(solanes): Add .bss support for BCP multi-image. + const bool is_multi_image = codegen->GetCompilerOptions().IsBootImage() || + codegen->GetCompilerOptions().IsBootImageExtension(); + *out_needs_bss_check = is_multi_image; return true; } |