Optimizing: Add `HInstruction::As##type()`.

After the old implementation was renamed in
    https://android-review.googlesource.com/2526708 ,
we introduce a new function with the old name but new
behavior, just `DCHECK()`-ing the instruction kind before
casting down the pointer. We change appropriate calls from
`As##type##OrNull()` to `As##type()` to avoid unncessary
run-time checks and reduce the size of libart-compiler.so.

Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing
Test: run-gtests.sh
Test: testrunner.py --target --optimizing
Bug: 181943478
Change-Id: I025681612a77ca2157fed4886ca47f2053975d4e

1 files changed, 1 insertions, 2 deletions

diff --git a/compiler/optimizing/induction_var_range.h b/compiler/optimizing/induction_var_range.h
index 356a04ab19..3e1212bec8 100644
--- a/compiler/optimizing/induction_var_range.h
+++ b/compiler/optimizing/induction_var_range.h
@@ -139,8 +139,7 @@ class InductionVarRange {
   void ReVisit(const HLoopInformation* loop) {
     induction_analysis_->induction_.erase(loop);
     for (HInstructionIterator it(loop->GetHeader()->GetPhis()); !it.Done(); it.Advance()) {
-      // TODO: Remove "OrNull".
-      induction_analysis_->cycles_.erase(it.Current()->AsPhiOrNull());
+      induction_analysis_->cycles_.erase(it.Current()->AsPhi());
     }
     induction_analysis_->VisitLoop(loop);
   }