Optimizing: Add `HInstruction::As##type()`.

After the old implementation was renamed in
    https://android-review.googlesource.com/2526708 ,
we introduce a new function with the old name but new
behavior, just `DCHECK()`-ing the instruction kind before
casting down the pointer. We change appropriate calls from
`As##type##OrNull()` to `As##type()` to avoid unncessary
run-time checks and reduce the size of libart-compiler.so.

Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing
Test: run-gtests.sh
Test: testrunner.py --target --optimizing
Bug: 181943478
Change-Id: I025681612a77ca2157fed4886ca47f2053975d4e

1 files changed, 2 insertions, 4 deletions

diff --git a/compiler/optimizing/gvn.cc b/compiler/optimizing/gvn.cc
index cccb381bc6..a6ca057cfc 100644
--- a/compiler/optimizing/gvn.cc
+++ b/compiler/optimizing/gvn.cc
@@ -498,12 +498,10 @@ void GlobalValueNumberer::VisitBasicBlock(HBasicBlock* block) {
     // Deoptimize is a special case since even though we don't want to move it we can still remove
     // it for GVN.
     if (current->CanBeMoved() || current->IsBoundType() || current->IsDeoptimize()) {
-      // TODO: Remove "OrNull".
-      if (current->IsBinaryOperation() && current->AsBinaryOperationOrNull()->IsCommutative()) {
+      if (current->IsBinaryOperation() && current->AsBinaryOperation()->IsCommutative()) {
         // For commutative ops, (x op y) will be treated the same as (y op x)
         // after fixed ordering.
-        // TODO: Remove "OrNull".
-        current->AsBinaryOperationOrNull()->OrderInputs();
+        current->AsBinaryOperation()->OrderInputs();
       }
       HInstruction* existing = set->Lookup(current);
       if (existing != nullptr) {