diff options
author | 2023-02-14 14:03:38 +0000 | |
---|---|---|
committer | 2023-02-15 14:07:32 +0000 | |
commit | b22e708890b61e6a82bb8a18e98413c2bd4933c9 (patch) | |
tree | c118b74fa4a64889eb59a0844b0384500901bae4 /compiler/optimizing/graph_checker.h | |
parent | 8cc1c0fc045623b86cd35e93deb23004b09a3d69 (diff) |
Remove RTI validation from our checks
It is possible to have untyped RTI in valid graphs due to e.g.
dead code, redundant phis not replaced yet. By removing this
validation, we shift the burden of the validation to the user
of the RTI.
Bug: 252799892
Fixes: 252799892
Test: art/test/testrunner/testrunner.py --host --64 --optimizing -b
Test: dex2oat compiling the apps in the bug
Change-Id: I112497bf10c180b651fd5b6e268799bc3abb27b3
Diffstat (limited to 'compiler/optimizing/graph_checker.h')
-rw-r--r-- | compiler/optimizing/graph_checker.h | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/compiler/optimizing/graph_checker.h b/compiler/optimizing/graph_checker.h index 674798e20b..d6644f3b50 100644 --- a/compiler/optimizing/graph_checker.h +++ b/compiler/optimizing/graph_checker.h @@ -68,6 +68,7 @@ class GraphChecker : public HGraphDelegateVisitor { void VisitInstanceOf(HInstanceOf* check) override; void VisitInvoke(HInvoke* invoke) override; void VisitInvokeStaticOrDirect(HInvokeStaticOrDirect* invoke) override; + void VisitLoadClass(HLoadClass* load) override; void VisitLoadException(HLoadException* load) override; void VisitMonitorOperation(HMonitorOperation* monitor_operation) override; void VisitNeg(HNeg* instruction) override; @@ -106,15 +107,6 @@ class GraphChecker : public HGraphDelegateVisitor { } } - // Enable/Disable the reference type info check. - // - // Return: the previous status of the check. - bool SetRefTypeInfoCheckEnabled(bool value = true) { - bool old_value = check_reference_type_info_; - check_reference_type_info_ = value; - return old_value; - } - protected: // Report a new error. void AddError(const std::string& error) { @@ -136,10 +128,6 @@ class GraphChecker : public HGraphDelegateVisitor { const char* const dump_prefix_; ScopedArenaAllocator allocator_; ArenaBitVector seen_ids_; - // Whether to perform the reference type info check for instructions which use or produce - // object references, e.g. HNewInstance, HLoadClass. - // The default value is true. - bool check_reference_type_info_ = true; // Used to access target information. CodeGenerator* codegen_; |