summaryrefslogtreecommitdiff
path: root/compiler/optimizing/graph_checker.h
diff options
context:
space:
mode:
author Santiago Aboy Solanes <solanes@google.com> 2024-01-23 13:55:50 +0000
committer Santiago Aboy Solanes <solanes@google.com> 2024-01-24 13:33:33 +0000
commit1be176f5a78750e2f0e32470f8c83e3d1643954d (patch)
tree5b6ba41dc94cebac7f65a2bb97355398094964b3 /compiler/optimizing/graph_checker.h
parent6799d71854007cb1efe2bb4dcceda9f0f4f0e0a3 (diff)
Revert^5 "Disable write-barrier elimination pass"
This reverts commit 31b949bc4a76e5c6d00a8e18c346f123b5321a1c. Reason for revert: PS1 is reland as-is PS2 has two fixes: * Missed poisoning heap references in a code path * Removed incorrect DCHECK Change-Id: I81b317ddc704dbd8a173f5d5c624dbc69e2d9e60 Test: art/test/testrunner/testrunner.py --host --64 --optimizing -b Test: art/test/testrunner/testrunner.py --target --64 --optimizing -b Both commnands with `export ART_HEAP_POISONING=true` Bug: 301833859 Bug: 310755375 Bug: 260843353
Diffstat (limited to 'compiler/optimizing/graph_checker.h')
-rw-r--r--compiler/optimizing/graph_checker.h5
1 files changed, 5 insertions, 0 deletions
diff --git a/compiler/optimizing/graph_checker.h b/compiler/optimizing/graph_checker.h
index 38e2d7ced9..5704bcec1a 100644
--- a/compiler/optimizing/graph_checker.h
+++ b/compiler/optimizing/graph_checker.h
@@ -59,6 +59,8 @@ class GraphChecker : public HGraphDelegateVisitor {
void VisitPhi(HPhi* phi) override;
void VisitArraySet(HArraySet* instruction) override;
+ void VisitInstanceFieldSet(HInstanceFieldSet* instruction) override;
+ void VisitStaticFieldSet(HStaticFieldSet* instruction) override;
void VisitBinaryOperation(HBinaryOperation* op) override;
void VisitBooleanNot(HBooleanNot* instruction) override;
void VisitBoundType(HBoundType* instruction) override;
@@ -93,6 +95,9 @@ class GraphChecker : public HGraphDelegateVisitor {
void HandleLoop(HBasicBlock* loop_header);
void HandleBooleanInput(HInstruction* instruction, size_t input_index);
+ template <typename GetWriteBarrierKind>
+ void CheckWriteBarrier(HInstruction* instruction, GetWriteBarrierKind&& get_write_barrier_kind);
+
// Was the last visit of the graph valid?
bool IsValid() const {
return errors_.empty();