diff options
author | 2015-04-15 16:29:32 +0100 | |
---|---|---|
committer | 2015-04-16 11:09:55 +0100 | |
commit | 13b4718ecd52a674b25eac106e654d8e89872750 (patch) | |
tree | 34d6efd2cda3ceb233118e4d135c4a897f02ea12 /compiler/optimizing/graph_checker.h | |
parent | da93333d568f3c5bd8eeb58341d10a332e1d42bf (diff) |
ART: Remove DCHECKs for boolean type
Since bool and int are interchangeable types, checking whether an
input is kPrimBoolean can fail when replaced with 0/1 constant or
a phi. This patch removes the problematic DCHECKs, adds a best-effort
verification into SSAChecker but leaves the phi case empty until a
suitable analysis is implemented.
Change-Id: I31e8daf27dd33d2fd74049b82bed1cb7c240c8c6
Diffstat (limited to 'compiler/optimizing/graph_checker.h')
-rw-r--r-- | compiler/optimizing/graph_checker.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/compiler/optimizing/graph_checker.h b/compiler/optimizing/graph_checker.h index 89fea0a07f..4568a5ef9d 100644 --- a/compiler/optimizing/graph_checker.h +++ b/compiler/optimizing/graph_checker.h @@ -107,8 +107,11 @@ class SSAChecker : public GraphChecker { void VisitBinaryOperation(HBinaryOperation* op) OVERRIDE; void VisitCondition(HCondition* op) OVERRIDE; void VisitIf(HIf* instruction) OVERRIDE; + void VisitBooleanNot(HBooleanNot* instruction) OVERRIDE; void VisitConstant(HConstant* instruction) OVERRIDE; + void HandleBooleanInput(HInstruction* instruction, size_t input_index); + private: DISALLOW_COPY_AND_ASSIGN(SSAChecker); }; |