summaryrefslogtreecommitdiff
path: root/compiler/optimizing/code_generator.cc
diff options
context:
space:
mode:
author Vladimir Marko <vmarko@google.com> 2019-06-10 11:10:38 +0100
committer Vladimir Marko <vmarko@google.com> 2019-06-12 08:44:25 +0000
commit8e05f09ca712c33bf2090cf03a3a8db858a23314 (patch)
treec78491d8a9ef33f4073d0053dfbd6417bbaa13a9 /compiler/optimizing/code_generator.cc
parent23df24822ee70fe255e6c02fb130112e28fdf63a (diff)
Do not force-intern Strings in images.
Interning all image Strings breaks the reference equality semantics. See android.net.Uri.NOT_CACHED for an example where it goes against the intent of the Java code. Instead, only put interned strings (weakly and strongly) to the image intern tables. Since image interns are referenced as long as the image is memory, we can promote weak interns to strong interns. Doing this before the image layout helps ImageWriter::CalculateNewObjectOffsets() which would not have previously found weak interns. Added a regression test that relies on better initialization of app image classes, so it shall be "active" only after an improvement in that area. (This can be checked by commenting out the NoClinitInDependency() check in CompilerDriver's InitializeClassVisitor::TryInitializeClass().) Bug: 134746125 Test: 176-app-image-string Test: m test-art-host-gtest Test: testrunner.py --host --optimizing Test: aosp_taimen-userdebug boots. Test: run-gtests.sh Test: testrunner.py --target --optimizing Change-Id: I51fa1edf953c9060c41f39812f3ba27f12b02801
Diffstat (limited to 'compiler/optimizing/code_generator.cc')
0 files changed, 0 insertions, 0 deletions