diff options
| author | 2020-05-11 16:55:55 +0100 | |
|---|---|---|
| committer | 2020-06-19 08:26:46 +0000 | |
| commit | 86c8752f64629325026945cd4eabd1dcea224acb (patch) | |
| tree | 9dc2be978f9e784a3ce16fa29d46941a94ac1c94 /compiler/jni/quick/calling_convention.h | |
| parent | f97a859e85f703644d897f0e3e1bc54315557aaa (diff) | |
Direct calls to @CriticalNative methods.
Emit direct calls from compiled managed code to the native
code registered with the method, avoiding the JNI stub.
Golem results:
art-opt-cc x86 x86-64 arm arm64
NativeDowncallStaticCritical +12.5% +62.5% +75.9% +41.7%
NativeDowncallStaticCritical6 +55.6% +87.5% +72.1% +35.3%
art-opt x86 x86-64 arm arm64
NativeDowncallStaticCritical +28.6% +85.6% +76.4% +38.4%
NativeDowncallStaticCritical6 +44.6% +44.6% +74.6% +32.2%
Test: Covered by 178-app-image-native-method.
Test: m test-art-host-gtest
Test: testrunner.py --host --debuggable --ndebuggable \
--optimizing --jit --jit-on-first-use
Test: run-gtests.sh
Test: testrunner.py --target --optimizing
Test: testrunner.py --target --debuggable --ndebuggable \
--optimizing --jit --jit-on-first-use -t 178
Test: aosp_cf_x86_phone-userdebug boots.
Test: aosp_cf_x86_phone-userdebug/jitzygote boots.
Bug: 112189621
Change-Id: I8b37da51e8fe0b7bc513bb81b127fe0416068866
Diffstat (limited to 'compiler/jni/quick/calling_convention.h')
| -rw-r--r-- | compiler/jni/quick/calling_convention.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/compiler/jni/quick/calling_convention.h b/compiler/jni/quick/calling_convention.h index b4396f0f0b..005ae910d1 100644 --- a/compiler/jni/quick/calling_convention.h +++ b/compiler/jni/quick/calling_convention.h @@ -303,9 +303,9 @@ class JniCallingConvention : public CallingConvention { // always at the bottom of a frame, but this doesn't work for outgoing // native args). Includes alignment. virtual size_t FrameSize() const = 0; - // Size of outgoing arguments (stack portion), including alignment. + // Size of outgoing frame, i.e. stack arguments, @CriticalNative return PC if needed, alignment. // -- Arguments that are passed via registers are excluded from this size. - virtual size_t OutArgSize() const = 0; + virtual size_t OutFrameSize() const = 0; // Number of references in stack indirect reference table size_t ReferenceCount() const; // Location where the segment state of the local indirect reference table is saved |