summaryrefslogtreecommitdiff
path: root/compiler/driver/compiler_options_map-inl.h
diff options
context:
space:
mode:
author Santiago Aboy Solanes <solanes@google.com> 2023-11-03 15:42:11 +0000
committer Santiago Aboy Solanes <solanes@google.com> 2023-11-06 14:37:04 +0000
commit4fd854d795a8d6d1572db8529945af3fe182ee4e (patch)
tree2ce2759d6a5ac41bb1e427cfb60327c953310665 /compiler/driver/compiler_options_map-inl.h
parentf987c5cf9c8be959fc1ab62cb0e1c29222cc9fc3 (diff)
Deprecate num-dex-methods and top-k-profile-threshold flags
They were unused and did nothing. Test: Presubmit Change-Id: Id651d5834afcdf293939b79d330b198aef0c954c
Diffstat (limited to 'compiler/driver/compiler_options_map-inl.h')
-rw-r--r--compiler/driver/compiler_options_map-inl.h19
1 files changed, 6 insertions, 13 deletions
diff --git a/compiler/driver/compiler_options_map-inl.h b/compiler/driver/compiler_options_map-inl.h
index 8530df37e4..4734950a2c 100644
--- a/compiler/driver/compiler_options_map-inl.h
+++ b/compiler/driver/compiler_options_map-inl.h
@@ -58,7 +58,6 @@ inline bool ReadCompilerOptions(Base& map, CompilerOptions* options, std::string
map.AssignIfExists(Base::CompileArtTest, &options->compile_art_test_);
map.AssignIfExists(Base::HugeMethodMaxThreshold, &options->huge_method_threshold_);
map.AssignIfExists(Base::LargeMethodMaxThreshold, &options->large_method_threshold_);
- map.AssignIfExists(Base::NumDexMethodsThreshold, &options->num_dex_methods_threshold_);
map.AssignIfExists(Base::InlineMaxCodeUnitsThreshold, &options->inline_max_code_units_);
map.AssignIfExists(Base::GenerateDebugInfo, &options->generate_debug_info_);
map.AssignIfExists(Base::GenerateMiniDebugInfo, &options->generate_mini_debug_info_);
@@ -69,7 +68,6 @@ inline bool ReadCompilerOptions(Base& map, CompilerOptions* options, std::string
if (map.Exists(Base::Baseline)) {
options->baseline_ = true;
}
- map.AssignIfExists(Base::TopKProfileThreshold, &options->top_k_profile_threshold_);
map.AssignIfExists(Base::AbortOnHardVerifierFailure, &options->abort_on_hard_verifier_failure_);
map.AssignIfExists(Base::AbortOnSoftVerifierFailure, &options->abort_on_soft_verifier_failure_);
if (map.Exists(Base::DumpInitFailures)) {
@@ -137,12 +135,6 @@ NO_INLINE void AddCompilerOptionsArgumentParserOptions(Builder& b) {
.template WithType<unsigned int>()
.WithHelp("threshold size for a large method for compiler filter tuning.")
.IntoKey(Map::LargeMethodMaxThreshold)
- .Define("--num-dex-methods=_")
- .template WithType<unsigned int>()
- .WithHelp("threshold size for a small dex file for compiler filter tuning. If the input\n"
- "has fewer than this many methods and the filter is not interpret-only or\n"
- "verify-none or verify-at-runtime, overrides the filter to use speed")
- .IntoKey(Map::NumDexMethodsThreshold)
.Define("--inline-max-code-units=_")
.template WithType<unsigned int>()
.WithHelp("the maximum code units that a methodcan have to be considered for inlining.\n"
@@ -206,10 +198,6 @@ NO_INLINE void AddCompilerOptionsArgumentParserOptions(Builder& b) {
.WithHelp("Produce code using the baseline compilation")
.IntoKey(Map::Baseline)
- .Define("--top-k-profile-threshold=_")
- .template WithType<double>().WithRange(0.0, 100.0)
- .IntoKey(Map::TopKProfileThreshold)
-
.Define({"--abort-on-hard-verifier-error", "--no-abort-on-hard-verifier-error"})
.WithValues({true, false})
.IntoKey(Map::AbortOnHardVerifierFailure)
@@ -256,7 +244,12 @@ NO_INLINE void AddCompilerOptionsArgumentParserOptions(Builder& b) {
.Define("--max-image-block-size=_")
.template WithType<unsigned int>()
.WithHelp("Maximum solid block size for compressed images.")
- .IntoKey(Map::MaxImageBlockSize);
+ .IntoKey(Map::MaxImageBlockSize)
+ // Obsolete flags
+ .Ignore({
+ "--num-dex-methods=_",
+ "--top-k-profile-threshold=_",
+ });
// clang-format on
}