summaryrefslogtreecommitdiff
path: root/compiler/driver/compiler_driver.cc
diff options
context:
space:
mode:
author Chang Xing <chxing@google.com> 2017-06-28 21:27:56 +0000
committer Chang Xing <chxing@google.com> 2017-06-28 16:43:51 -0700
commitba17dbd5f23d6f6acf3fb60b6dd65dc34bd833de (patch)
treef4edd3f059665f0ed7fe2e9506c7f9508f727be3 /compiler/driver/compiler_driver.cc
parent3dc94c4763ecab28c0053d5d07e332c61a3f781b (diff)
Revert "Revert "Fixed Literal String intern mismatch.""
This reverts commit f7ab8348b88b7ce63c5fa112f5a71756da541763. Test: make test-ar-host -j64 Change-Id: I688b7c7905c8be575959fa78ad594ac1c782af9a
Diffstat (limited to 'compiler/driver/compiler_driver.cc')
-rw-r--r--compiler/driver/compiler_driver.cc26
1 files changed, 1 insertions, 25 deletions
diff --git a/compiler/driver/compiler_driver.cc b/compiler/driver/compiler_driver.cc
index 622448fc59..7e0047108a 100644
--- a/compiler/driver/compiler_driver.cc
+++ b/compiler/driver/compiler_driver.cc
@@ -2406,30 +2406,6 @@ class InitializeClassVisitor : public CompilationVisitor {
}
}
- bool NoPotentialInternStrings(Handle<mirror::Class> klass,
- Handle<mirror::ClassLoader>* class_loader)
- REQUIRES_SHARED(Locks::mutator_lock_) {
- StackHandleScope<1> hs(Thread::Current());
- Handle<mirror::DexCache> h_dex_cache = hs.NewHandle(klass->GetDexCache());
- const DexFile* dex_file = h_dex_cache->GetDexFile();
- const DexFile::ClassDef* class_def = klass->GetClassDef();
- annotations::RuntimeEncodedStaticFieldValueIterator value_it(*dex_file,
- &h_dex_cache,
- class_loader,
- manager_->GetClassLinker(),
- *class_def);
-
- const auto jString = annotations::RuntimeEncodedStaticFieldValueIterator::kString;
- for ( ; value_it.HasNext(); value_it.Next()) {
- if (value_it.GetValueType() == jString) {
- // We don't want cache the static encoded strings which is a potential intern.
- return false;
- }
- }
-
- return true;
- }
-
bool ResolveTypesOfMethods(Thread* self, ArtMethod* m)
REQUIRES_SHARED(Locks::mutator_lock_) {
auto rtn_type = m->GetReturnType(true); // return value is discarded because resolve will be done internally.
@@ -2559,7 +2535,7 @@ class InitializeClassVisitor : public CompilationVisitor {
}
}
- return NoPotentialInternStrings(klass, class_loader);
+ return true;
}
const ParallelCompilationManager* const manager_;