diff options
| author | 2017-05-31 21:07:28 +0000 | |
|---|---|---|
| committer | 2017-05-31 21:07:30 +0000 | |
| commit | 854461a4cd5e4a38debe3616e12b52fe7f160782 (patch) | |
| tree | 55a7399b859787403f1e032b611a889a99b3a7de /compiler/driver/compiler_driver.cc | |
| parent | 85b82e35d810a21257fec9d850d95f8abc900670 (diff) | |
| parent | 762ef842d78b6f8a76f2b119504f075728540077 (diff) | |
Merge "Fixed Literal String intern mismatch."
Diffstat (limited to 'compiler/driver/compiler_driver.cc')
| -rw-r--r-- | compiler/driver/compiler_driver.cc | 28 |
1 files changed, 2 insertions, 26 deletions
diff --git a/compiler/driver/compiler_driver.cc b/compiler/driver/compiler_driver.cc index 70c3f6098a..3fdfb31b9b 100644 --- a/compiler/driver/compiler_driver.cc +++ b/compiler/driver/compiler_driver.cc @@ -2424,33 +2424,9 @@ class InitializeClassVisitor : public CompilationVisitor { } } - bool NoPotentialInternStrings(Handle<mirror::Class> klass, - Handle<mirror::ClassLoader>* class_loader) - REQUIRES_SHARED(Locks::mutator_lock_) { - StackHandleScope<1> hs(Thread::Current()); - Handle<mirror::DexCache> h_dex_cache = hs.NewHandle(klass->GetDexCache()); - const DexFile* dex_file = h_dex_cache->GetDexFile(); - const DexFile::ClassDef* class_def = klass->GetClassDef(); - annotations::RuntimeEncodedStaticFieldValueIterator value_it(*dex_file, - &h_dex_cache, - class_loader, - manager_->GetClassLinker(), - *class_def); - - const auto jString = annotations::RuntimeEncodedStaticFieldValueIterator::kString; - for ( ; value_it.HasNext(); value_it.Next()) { - if (value_it.GetValueType() == jString) { - // We don't want cache the static encoded strings which is a potential intern. - return false; - } - } - - return true; - } - bool ResolveTypesOfMethods(Thread* self, ArtMethod* m) REQUIRES_SHARED(Locks::mutator_lock_) { - auto rtn_type = m->GetReturnType(true); // return value is discarded because resolve will be done internally. + auto rtn_type = m->GetReturnType(true); if (rtn_type == nullptr) { self->ClearException(); return false; @@ -2575,7 +2551,7 @@ class InitializeClassVisitor : public CompilationVisitor { return false; } - return NoPotentialInternStrings(klass, class_loader); + return true; } const ParallelCompilationManager* const manager_; |