summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Florian Mayer <fmayer@google.com> 2022-10-20 17:33:51 +0000
committer David Srbecky <dsrbecky@google.com> 2022-10-20 19:16:13 +0000
commitfee4f9f596a74e720984ac15acd10fc54c53b7c5 (patch)
treec95fed40f7f344ecd45ed162148023c0ff6c0afe
parente772458a32ef55e68d15a08d95df2d97fa6ef22a (diff)
explain why we need to disable hwasan
Bug: 254365701 Change-Id: I2d67903608593fe3aeafea347a6c4a375a4295c2
-rw-r--r--sigchainlib/sigchain_test.cc2
1 files changed, 2 insertions, 0 deletions
diff --git a/sigchainlib/sigchain_test.cc b/sigchainlib/sigchain_test.cc
index 7d5d5f0476..5e9c7fe7cb 100644
--- a/sigchainlib/sigchain_test.cc
+++ b/sigchainlib/sigchain_test.cc
@@ -256,6 +256,8 @@ TEST_F(SigchainTest, EnsureFrontOfChain) {
}
#if defined(__aarch64__)
+// The test intentionally dereferences (tagged) null to trigger SIGSEGV.
+// We need to disable HWASAN since it would catch the dereference first.
DISABLE_HWASAN void fault_address_tag_impl() {
struct sigaction action = {};
action.sa_flags = SA_SIGINFO;