diff options
author | 2023-11-07 14:09:26 +0000 | |
---|---|---|
committer | 2023-11-08 07:55:17 +0000 | |
commit | f18b0f6bd156546ed2a358c3337671e9f3237a67 (patch) | |
tree | a67a17e46bc0e15e5f61a53bf33cb20b7555a2bd | |
parent | 13f4d284839c28390a5526200a21037b31fd0c9a (diff) |
Replace if..else if..else with switch statement in metrics_test.cc
This change was suggested in a style comment in aosp/2756388 after it was submitted
Bug: 300070371
Test: art/test/testrunner/run_build_test_target.py -j80 art-gtest-ss-gc
Change-Id: If9dbacea7cbad022d2e559bed4226a4e6b3be697
-rw-r--r-- | libartbase/base/metrics/metrics_test.cc | 21 |
1 files changed, 12 insertions, 9 deletions
diff --git a/libartbase/base/metrics/metrics_test.cc b/libartbase/base/metrics/metrics_test.cc index 2a0f251eeb..bcc4da4e06 100644 --- a/libartbase/base/metrics/metrics_test.cc +++ b/libartbase/base/metrics/metrics_test.cc @@ -199,15 +199,18 @@ TEST_F(MetricsTest, ArtMetricsReport) { } void ReportCounter(DatumId counter_type, uint64_t value) override { - if (counter_type == DatumId::kClassVerificationTotalTime) { - EXPECT_EQ(value, verification_time) - << "Unexpected value for counter " << DatumName(counter_type); - found_counter_ = true; - } else if (counter_type == DatumId::kTimeElapsedDelta) { - // TimeElapsedData can be greater than 0 if the test takes more than 1ms to run - EXPECT_GE(value, 0u) << "Unexpected value for counter " << DatumName(counter_type); - } else { - EXPECT_EQ(value, 0u) << "Unexpected value for counter " << DatumName(counter_type); + switch (counter_type) { + case DatumId::kClassVerificationTotalTime: + EXPECT_EQ(value, verification_time) + << "Unexpected value for counter " << DatumName(counter_type); + found_counter_ = true; + break; + case DatumId::kTimeElapsedDelta: + // TimeElapsedData can be greater than 0 if the test takes more than 1ms to run + EXPECT_GE(value, 0u) << "Unexpected value for counter " << DatumName(counter_type); + break; + default: + EXPECT_EQ(value, 0u) << "Unexpected value for counter " << DatumName(counter_type); } } |