diff options
| author | 2018-06-14 16:31:40 +0100 | |
|---|---|---|
| committer | 2018-06-19 15:00:41 +0100 | |
| commit | e464f1f08bb66e36752a67e17c1a6da7abbe7708 (patch) | |
| tree | c1c9011cf643f2f15f1a0734aa70514815afcc9d | |
| parent | 0b0d3b421782fbe04085765df9e99fb05a93a01c (diff) | |
Re-enable some more ART gtests when running under ASan.
Some tests in heap_verification_test and runtime_callbacks_test were
disabled when running under a memory tool, but they seem to work fine
when run under AddressSanitizer on host. They were presubmably
disabled because of issues with Valgrind. Enable them unconditionally,
as Valgrind support has been dropped from ART.
Test: SANITIZE_HOST=address ASAN_OPTIONS='detect_leaks=0' make test-art-host-heap_verification_test
Bug: 29282211
Bug: 62448488
Change-Id: Ic143e9c2f37420f770716d58ca603438198e413b
| -rw-r--r-- | runtime/gc/heap_verification_test.cc | 4 | ||||
| -rw-r--r-- | runtime/runtime_callbacks_test.cc | 3 |
2 files changed, 0 insertions, 7 deletions
diff --git a/runtime/gc/heap_verification_test.cc b/runtime/gc/heap_verification_test.cc index 38695332bb..e0c7faf56d 100644 --- a/runtime/gc/heap_verification_test.cc +++ b/runtime/gc/heap_verification_test.cc @@ -83,7 +83,6 @@ TEST_F(VerificationTest, IsValidClassOrNotInHeap) { } TEST_F(VerificationTest, IsValidClassInHeap) { - TEST_DISABLED_FOR_MEMORY_TOOL(); ScopedObjectAccess soa(Thread::Current()); VariableSizedHandleScope hs(soa.Self()); Handle<mirror::String> string( @@ -106,7 +105,6 @@ TEST_F(VerificationTest, DumpInvalidObjectInfo) { } TEST_F(VerificationTest, DumpValidObjectInfo) { - TEST_DISABLED_FOR_MEMORY_TOOL(); ScopedLogSeverity sls(LogSeverity::INFO); ScopedObjectAccess soa(Thread::Current()); Runtime* const runtime = Runtime::Current(); @@ -126,7 +124,6 @@ TEST_F(VerificationTest, DumpValidObjectInfo) { } TEST_F(VerificationTest, LogHeapCorruption) { - TEST_DISABLED_FOR_MEMORY_TOOL(); ScopedLogSeverity sls(LogSeverity::INFO); ScopedObjectAccess soa(Thread::Current()); Runtime* const runtime = Runtime::Current(); @@ -147,7 +144,6 @@ TEST_F(VerificationTest, LogHeapCorruption) { } TEST_F(VerificationTest, FindPathFromRootSet) { - TEST_DISABLED_FOR_MEMORY_TOOL(); ScopedLogSeverity sls(LogSeverity::INFO); ScopedObjectAccess soa(Thread::Current()); Runtime* const runtime = Runtime::Current(); diff --git a/runtime/runtime_callbacks_test.cc b/runtime/runtime_callbacks_test.cc index 54769f9c49..794ac19c4b 100644 --- a/runtime/runtime_callbacks_test.cc +++ b/runtime/runtime_callbacks_test.cc @@ -339,9 +339,6 @@ class RuntimeSigQuitCallbackRuntimeCallbacksTest : public RuntimeCallbacksTest { }; TEST_F(RuntimeSigQuitCallbackRuntimeCallbacksTest, SigQuit) { - // SigQuit induces a dump. ASan isn't happy with libunwind reading memory. - TEST_DISABLED_FOR_MEMORY_TOOL(); - // The runtime needs to be started for the signal handler. Thread* self = Thread::Current(); |