diff options
author | 2023-03-30 10:27:44 +0200 | |
---|---|---|
committer | 2023-03-30 10:20:26 +0000 | |
commit | c98458f25c0afa7c3487e84c43ffc63483c2b2a9 (patch) | |
tree | 1e32fdb94a72a54b5c9e700236cabf1f5281d08a | |
parent | c1fcd6a94a1a6fcf1853041243dfb81310600633 (diff) |
arm/arm64: Minor cleanup in assemblers.
Test: m test-art-host-gtest
Change-Id: Ic1ca6fa6c5ec954be9de0dfab49e3c47ade4fd69
-rw-r--r-- | compiler/utils/arm/assembler_arm_shared.h | 48 | ||||
-rw-r--r-- | compiler/utils/arm/assembler_arm_vixl.h | 22 | ||||
-rw-r--r-- | compiler/utils/arm/jni_macro_assembler_arm_vixl.h | 1 | ||||
-rw-r--r-- | compiler/utils/arm64/assembler_arm64.cc | 1 | ||||
-rw-r--r-- | compiler/utils/arm64/assembler_arm64.h | 1 |
5 files changed, 20 insertions, 53 deletions
diff --git a/compiler/utils/arm/assembler_arm_shared.h b/compiler/utils/arm/assembler_arm_shared.h deleted file mode 100644 index 77118c88ef..0000000000 --- a/compiler/utils/arm/assembler_arm_shared.h +++ /dev/null @@ -1,48 +0,0 @@ -/* - * Copyright (C) 2016 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -#ifndef ART_COMPILER_UTILS_ARM_ASSEMBLER_ARM_SHARED_H_ -#define ART_COMPILER_UTILS_ARM_ASSEMBLER_ARM_SHARED_H_ - -#include "base/macros.h" - -namespace art HIDDEN { -namespace arm { - -enum LoadOperandType { - kLoadSignedByte, - kLoadUnsignedByte, - kLoadSignedHalfword, - kLoadUnsignedHalfword, - kLoadWord, - kLoadWordPair, - kLoadSWord, - kLoadDWord -}; - -enum StoreOperandType { - kStoreByte, - kStoreHalfword, - kStoreWord, - kStoreWordPair, - kStoreSWord, - kStoreDWord -}; - -} // namespace arm -} // namespace art - -#endif // ART_COMPILER_UTILS_ARM_ASSEMBLER_ARM_SHARED_H_ diff --git a/compiler/utils/arm/assembler_arm_vixl.h b/compiler/utils/arm/assembler_arm_vixl.h index 93775316b3..741119d7f7 100644 --- a/compiler/utils/arm/assembler_arm_vixl.h +++ b/compiler/utils/arm/assembler_arm_vixl.h @@ -19,12 +19,10 @@ #include <android-base/logging.h> -#include "base/arena_containers.h" #include "base/macros.h" #include "constants_arm.h" #include "dwarf/register.h" #include "offsets.h" -#include "utils/arm/assembler_arm_shared.h" #include "utils/arm/managed_register_arm.h" #include "utils/assembler.h" @@ -47,6 +45,26 @@ inline dwarf::Reg DWARFReg(vixl32::SRegister reg) { return dwarf::Reg::ArmFp(static_cast<int>(reg.GetCode())); } +enum LoadOperandType { + kLoadSignedByte, + kLoadUnsignedByte, + kLoadSignedHalfword, + kLoadUnsignedHalfword, + kLoadWord, + kLoadWordPair, + kLoadSWord, + kLoadDWord +}; + +enum StoreOperandType { + kStoreByte, + kStoreHalfword, + kStoreWord, + kStoreWordPair, + kStoreSWord, + kStoreDWord +}; + class ArmVIXLMacroAssembler final : public vixl32::MacroAssembler { public: // Most methods fit in a 1KB code buffer, which results in more optimal alloc/realloc and diff --git a/compiler/utils/arm/jni_macro_assembler_arm_vixl.h b/compiler/utils/arm/jni_macro_assembler_arm_vixl.h index bcc40c4016..7f8fd0a611 100644 --- a/compiler/utils/arm/jni_macro_assembler_arm_vixl.h +++ b/compiler/utils/arm/jni_macro_assembler_arm_vixl.h @@ -23,7 +23,6 @@ #include "base/macros.h" #include "constants_arm.h" #include "offsets.h" -#include "utils/arm/assembler_arm_shared.h" #include "utils/arm/assembler_arm_vixl.h" #include "utils/arm/managed_register_arm.h" #include "utils/assembler.h" diff --git a/compiler/utils/arm64/assembler_arm64.cc b/compiler/utils/arm64/assembler_arm64.cc index cc50883350..26dce7c502 100644 --- a/compiler/utils/arm64/assembler_arm64.cc +++ b/compiler/utils/arm64/assembler_arm64.cc @@ -16,7 +16,6 @@ #include "arch/arm64/instruction_set_features_arm64.h" #include "assembler_arm64.h" -#include "base/bit_utils_iterator.h" #include "entrypoints/quick/quick_entrypoints.h" #include "heap_poisoning.h" #include "offsets.h" diff --git a/compiler/utils/arm64/assembler_arm64.h b/compiler/utils/arm64/assembler_arm64.h index 62f807f998..f8168903bd 100644 --- a/compiler/utils/arm64/assembler_arm64.h +++ b/compiler/utils/arm64/assembler_arm64.h @@ -23,7 +23,6 @@ #include <android-base/logging.h> -#include "base/arena_containers.h" #include "base/bit_utils_iterator.h" #include "base/macros.h" #include "dwarf/register.h" |