diff options
author | 2018-11-01 22:45:29 -0700 | |
---|---|---|
committer | 2018-11-01 22:45:47 -0700 | |
commit | bf44f151b735364434fb886d43b78ea0b47d08be (patch) | |
tree | d259e9460372ca27edda3ec1e7d2a463546bdcaa | |
parent | 1e152a6090c546f4a6184a5610c85cae7ac77068 (diff) |
Update 624-checker-stringops and 911-get-stack-trace.
After https://r8-review.googlesource.com/29460, D8/R8 canonicalize
const-string if possible.
Two ART tests have some constant strings, which are canonicalized by
that optimization, while outputs still expect constant loading.
For 624-checker-stringops, we can use different constants without
changing test expectations.
For 911-get-stack-trace, every `doTest()` starts with, e.g.,
System.out.println("######");
System.out.println("message");
System.out.println("######");
and one of #'s is canonicalized, hence consistenlty shifted offset in
expected outputs.
Test: art/test/testrunner/testrunner.py -b --host -t 624-checker-stringops
Test: art/test/testrunner/testrunner.py -b --host -t 911-get-stack-trace
Bug: 118235919
Change-Id: I4432fdf3e3d9cda111d0726ce930c935f2c334f0
-rw-r--r-- | test/624-checker-stringops/smali/Smali.smali | 4 | ||||
-rw-r--r-- | test/624-checker-stringops/src/Main.java | 4 | ||||
-rw-r--r-- | test/911-get-stack-trace/expected.txt | 16 |
3 files changed, 12 insertions, 12 deletions
diff --git a/test/624-checker-stringops/smali/Smali.smali b/test/624-checker-stringops/smali/Smali.smali index 8600a0a065..f8b92759c7 100644 --- a/test/624-checker-stringops/smali/Smali.smali +++ b/test/624-checker-stringops/smali/Smali.smali @@ -34,7 +34,7 @@ invoke-virtual {v0, v1}, Ljava/lang/StringBuffer;->append(Ljava/lang/String;)Ljava/lang/StringBuffer; move-result-object v1 - const-string v2, "x" + const-string v2, "y" invoke-virtual {v1, v2}, Ljava/lang/StringBuffer;->append(Ljava/lang/String;)Ljava/lang/StringBuffer; move-result-object v1 @@ -70,7 +70,7 @@ invoke-virtual {v0, v1}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder; move-result-object v1 - const-string v2, "x" + const-string v2, "y" invoke-virtual {v1, v2}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder; move-result-object v1 diff --git a/test/624-checker-stringops/src/Main.java b/test/624-checker-stringops/src/Main.java index 3aa6e563fc..f52d81a053 100644 --- a/test/624-checker-stringops/src/Main.java +++ b/test/624-checker-stringops/src/Main.java @@ -120,7 +120,7 @@ public class Main { /// CHECK-DAG: InvokeVirtual [<<New>>] intrinsic:StringBufferLength static int bufferLen2() { StringBuffer s = new StringBuffer(); - return s.append("x").append("x").length(); + return s.append("x").append("y").length(); } static int bufferLen2Smali() throws Exception { @@ -150,7 +150,7 @@ public class Main { /// CHECK-DAG: InvokeVirtual [<<New>>] intrinsic:StringBuilderLength static int builderLen2() { StringBuilder s = new StringBuilder(); - return s.append("x").append("x").length(); + return s.append("x").append("y").length(); } static int builderLen2Smali() throws Exception { diff --git a/test/911-get-stack-trace/expected.txt b/test/911-get-stack-trace/expected.txt index b0a400ab75..8dd49aaa9b 100644 --- a/test/911-get-stack-trace/expected.txt +++ b/test/911-get-stack-trace/expected.txt @@ -21,7 +21,7 @@ From top baz (IIILart/ControlData;)Ljava/lang/Object; 8 34 bar (IIILart/ControlData;)J 0 26 foo (IIILart/ControlData;)I 0 21 - doTest ()V 33 25 + doTest ()V 31 25 run ()V 0 25 --------- print (Ljava/lang/Thread;II)V 0 38 @@ -41,7 +41,7 @@ From top baz (IIILart/ControlData;)Ljava/lang/Object; 8 34 bar (IIILart/ControlData;)J 0 26 foo (IIILart/ControlData;)I 0 21 - doTest ()V 37 26 + doTest ()V 35 26 run ()V 0 25 --------- getStackTrace (Ljava/lang/Thread;II)[[Ljava/lang/String; -1 -2 @@ -62,7 +62,7 @@ From bottom baz (IIILart/ControlData;)Ljava/lang/Object; 8 34 bar (IIILart/ControlData;)J 0 26 foo (IIILart/ControlData;)I 0 21 - doTest ()V 60 32 + doTest ()V 58 32 run ()V 0 25 --------- bar (IIILart/ControlData;)J 0 26 @@ -388,7 +388,7 @@ Signal Catcher Test911 getAllStackTraces (I)[[Ljava/lang/Object; -1 -2 printAll (I)V 0 75 - doTest ()V 120 59 + doTest ()V 118 59 run ()V 24 37 --------- @@ -643,7 +643,7 @@ Signal Catcher Test911 getAllStackTraces (I)[[Ljava/lang/Object; -1 -2 printAll (I)V 0 75 - doTest ()V 125 61 + doTest ()V 123 61 run ()V 24 37 --------- @@ -675,7 +675,7 @@ ThreadListTraces Thread 8 Test911 getThreadListStackTraces ([Ljava/lang/Thread;I)[[Ljava/lang/Object; -1 -2 printList ([Ljava/lang/Thread;I)V 0 68 - doTest ()V 110 54 + doTest ()V 108 54 run ()V 32 41 --------- @@ -732,7 +732,7 @@ ThreadListTraces Thread 8 Test911 getThreadListStackTraces ([Ljava/lang/Thread;I)[[Ljava/lang/Object; -1 -2 printList ([Ljava/lang/Thread;I)V 0 68 - doTest ()V 115 56 + doTest ()V 113 56 run ()V 32 41 --------- @@ -857,7 +857,7 @@ ThreadListTraces Thread 8 4 JVMTI_ERROR_ILLEGAL_ARGUMENT [public static native java.lang.Object[] art.Frames.getFrameLocation(java.lang.Thread,int), ffffffff] -[public static void art.Frames.doTestSameThread(), 40] +[public static void art.Frames.doTestSameThread(), 3e] [public static void art.Frames.doTest() throws java.lang.Exception, 0] [public void art.Test911$1.run(), 28] JVMTI_ERROR_NO_MORE_FRAMES |