summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Daniel Riazanovskiy <riazanovskiy@google.com> 2020-10-15 17:31:01 +0000
committer Roland Levillain <rpl@google.com> 2020-10-16 10:50:19 +0000
commitb3ab635ecf561954336cc7b09d6f66a401d1d0fe (patch)
tree4677f3db808f9a92374f12797a5027abecb4d43b
parent6ebe40fce5927e3f40ec1d375590648d48d458f0 (diff)
Revert "Disable x86 FromCpuFeatures test"
This reverts commit 0713ca0525579365ae927ac800797a7473d9267f. Reason for revert: bug with simd extension not being detected on some CPUs is fixed in cpu_features (see https://android-review.googlesource.com/c/platform/external/cpu_features/+/1460885) Bug: 169921883 Change-Id: Ibce2c5ca923ec34f8b2350bae85fbe383952be25
-rw-r--r--runtime/arch/instruction_set_features_test.cc8
1 files changed, 0 insertions, 8 deletions
diff --git a/runtime/arch/instruction_set_features_test.cc b/runtime/arch/instruction_set_features_test.cc
index e926147f52..82b8242cfe 100644
--- a/runtime/arch/instruction_set_features_test.cc
+++ b/runtime/arch/instruction_set_features_test.cc
@@ -177,14 +177,6 @@ TEST(InstructionSetFeaturesTest, FeaturesFromAssembly) {
}
TEST(InstructionSetFeaturesTest, FeaturestFromCpuFeatures) {
- // Test globally disabled on x86 because of cpu_features not detecting SSSE3,
- // SSE4.1 and SSE4.2 extensions on fugu's CPU
- // (see https://github.com/google/cpu_features/issues/4)
- // TODO(b/169921883): Re-enable when cpu_features detects these CPU features
- // when running on fugu.
-
- TEST_DISABLED_FOR_X86();
-
// Take the default set of instruction features from the build.
std::unique_ptr<const InstructionSetFeatures> instruction_set_features(
InstructionSetFeatures::FromCppDefines());