diff options
author | 2015-05-06 18:27:35 +0100 | |
---|---|---|
committer | 2015-05-19 15:36:53 +0100 | |
commit | ad5fa8c5b26a325dc2a9521b87188755046c17f3 (patch) | |
tree | 1be28a827fe9e186196ad744eaa3438c1bea3f0a | |
parent | cfee0507f26375fe048ed35f402e61f904db0095 (diff) |
Support generation of CFI in .debug_frame format.
.debug_frame section is almost identical to .eh_frame section.
There are only minor differences in the CIE and FDE headers.
The main difference is that .eh_frame is intended to be used
at runtime for exception handling and is therefore allocated
within the running program whereas .debug_frame is not.
This makes .debug_frame easier to remove using standard tools.
"objcopy --strip-debug" removes .debug_frame, but not .eh_frame.
(although objcopy can be still be forced to remove .eh_frame)
Similarly, we might want to separate the CFI to separate debug
file or include it as compressed .gnu_debugdata section.
It is more appropriate to use .debug_frame for this purpose.
Bug:20556771
Change-Id: I9d91a333b9fb37523fd6fafccfad89b21d2477af
-rw-r--r-- | compiler/cfi_test.h | 12 | ||||
-rw-r--r-- | compiler/dwarf/dwarf_constants.h | 8 | ||||
-rw-r--r-- | compiler/dwarf/dwarf_test.cc | 36 | ||||
-rw-r--r-- | compiler/dwarf/dwarf_test.h | 10 | ||||
-rw-r--r-- | compiler/dwarf/headers.h | 43 | ||||
-rw-r--r-- | compiler/elf_writer_debug.cc | 105 | ||||
-rw-r--r-- | compiler/elf_writer_debug.h | 15 | ||||
-rw-r--r-- | compiler/elf_writer_quick.cc | 38 | ||||
-rw-r--r-- | runtime/elf_file.cc | 28 |
9 files changed, 174 insertions, 121 deletions
diff --git a/compiler/cfi_test.h b/compiler/cfi_test.h index f7501d2dda..5e345dbf61 100644 --- a/compiler/cfi_test.h +++ b/compiler/cfi_test.h @@ -30,6 +30,8 @@ namespace art { +constexpr dwarf::CFIFormat kCFIFormat = dwarf::DW_DEBUG_FRAME_FORMAT; + class CFITest : public dwarf::DwarfTest { public: void GenerateExpected(FILE* f, InstructionSet isa, const char* isa_str, @@ -46,11 +48,11 @@ class CFITest : public dwarf::DwarfTest { // Pretty-print CFI opcodes. constexpr bool is64bit = false; dwarf::DebugFrameOpCodeWriter<> initial_opcodes; - dwarf::WriteEhFrameCIE(is64bit, dwarf::DW_EH_PE_absptr, dwarf::Reg(8), - initial_opcodes, &eh_frame_data_); - std::vector<uintptr_t> eh_frame_patches; - dwarf::WriteEhFrameFDE(is64bit, 0, 0, actual_asm.size(), &actual_cfi, - &eh_frame_data_, &eh_frame_patches); + dwarf::WriteDebugFrameCIE(is64bit, dwarf::DW_EH_PE_absptr, dwarf::Reg(8), + initial_opcodes, kCFIFormat, &debug_frame_data_); + std::vector<uintptr_t> debug_frame_patches; + dwarf::WriteDebugFrameFDE(is64bit, 0, 0, actual_asm.size(), &actual_cfi, + kCFIFormat, &debug_frame_data_, &debug_frame_patches); ReformatCfi(Objdump(false, "-W"), &lines); // Pretty-print assembly. auto* opts = new DisassemblerOptions(false, actual_asm.data(), true); diff --git a/compiler/dwarf/dwarf_constants.h b/compiler/dwarf/dwarf_constants.h index 61a44cdabc..3b570e572a 100644 --- a/compiler/dwarf/dwarf_constants.h +++ b/compiler/dwarf/dwarf_constants.h @@ -680,6 +680,14 @@ enum ExceptionHeaderValueApplication : uint8_t { DW_EH_PE_aligned = 0x50, }; +enum CFIFormat : uint8_t { + // This is the original format as defined by the specification. + // It is used for the .debug_frame section. + DW_DEBUG_FRAME_FORMAT, + // Slightly modified format used for the .eh_frame section. + DW_EH_FRAME_FORMAT +}; + } // namespace dwarf } // namespace art diff --git a/compiler/dwarf/dwarf_test.cc b/compiler/dwarf/dwarf_test.cc index edba00aeaa..4971f0ef10 100644 --- a/compiler/dwarf/dwarf_test.cc +++ b/compiler/dwarf/dwarf_test.cc @@ -26,6 +26,8 @@ namespace art { namespace dwarf { +constexpr CFIFormat kCFIFormat = DW_DEBUG_FRAME_FORMAT; + // Run the tests only on host since we need objdump. #ifndef HAVE_ANDROID_OS @@ -120,30 +122,30 @@ TEST_F(DwarfTest, DebugFrame) { DW_CHECK_NEXT("DW_CFA_restore: r5 (ebp)"); DebugFrameOpCodeWriter<> initial_opcodes; - WriteEhFrameCIE(is64bit, DW_EH_PE_absptr, Reg(is64bit ? 16 : 8), - initial_opcodes, &eh_frame_data_); - std::vector<uintptr_t> eh_frame_patches; + WriteDebugFrameCIE(is64bit, DW_EH_PE_absptr, Reg(is64bit ? 16 : 8), + initial_opcodes, kCFIFormat, &debug_frame_data_); + std::vector<uintptr_t> debug_frame_patches; std::vector<uintptr_t> expected_patches { 28 }; // NOLINT - WriteEhFrameFDE(is64bit, 0, 0x01000000, 0x01000000, opcodes.data(), - &eh_frame_data_, &eh_frame_patches); + WriteDebugFrameFDE(is64bit, 0, 0x01000000, 0x01000000, opcodes.data(), + kCFIFormat, &debug_frame_data_, &debug_frame_patches); - EXPECT_EQ(expected_patches, eh_frame_patches); + EXPECT_EQ(expected_patches, debug_frame_patches); CheckObjdumpOutput(is64bit, "-W"); } TEST_F(DwarfTest, DebugFrame64) { constexpr bool is64bit = true; DebugFrameOpCodeWriter<> initial_opcodes; - WriteEhFrameCIE(is64bit, DW_EH_PE_absptr, Reg(16), - initial_opcodes, &eh_frame_data_); + WriteDebugFrameCIE(is64bit, DW_EH_PE_absptr, Reg(16), + initial_opcodes, kCFIFormat, &debug_frame_data_); DebugFrameOpCodeWriter<> opcodes; - std::vector<uintptr_t> eh_frame_patches; + std::vector<uintptr_t> debug_frame_patches; std::vector<uintptr_t> expected_patches { 32 }; // NOLINT - WriteEhFrameFDE(is64bit, 0, 0x0100000000000000, 0x0200000000000000, - opcodes.data(), &eh_frame_data_, &eh_frame_patches); + WriteDebugFrameFDE(is64bit, 0, 0x0100000000000000, 0x0200000000000000, + opcodes.data(), kCFIFormat, &debug_frame_data_, &debug_frame_patches); DW_CHECK("FDE cie=00000000 pc=100000000000000..300000000000000"); - EXPECT_EQ(expected_patches, eh_frame_patches); + EXPECT_EQ(expected_patches, debug_frame_patches); CheckObjdumpOutput(is64bit, "-W"); } @@ -173,11 +175,11 @@ TEST_F(DwarfTest, x86_64_RegisterMapping) { DW_CHECK_NEXT("DW_CFA_offset: r14 (r14)"); DW_CHECK_NEXT("DW_CFA_offset: r15 (r15)"); DebugFrameOpCodeWriter<> initial_opcodes; - WriteEhFrameCIE(is64bit, DW_EH_PE_absptr, Reg(16), - initial_opcodes, &eh_frame_data_); - std::vector<uintptr_t> eh_frame_patches; - WriteEhFrameFDE(is64bit, 0, 0x0100000000000000, 0x0200000000000000, - opcodes.data(), &eh_frame_data_, &eh_frame_patches); + WriteDebugFrameCIE(is64bit, DW_EH_PE_absptr, Reg(16), + initial_opcodes, kCFIFormat, &debug_frame_data_); + std::vector<uintptr_t> debug_frame_patches; + WriteDebugFrameFDE(is64bit, 0, 0x0100000000000000, 0x0200000000000000, + opcodes.data(), kCFIFormat, &debug_frame_data_, &debug_frame_patches); CheckObjdumpOutput(is64bit, "-W"); } diff --git a/compiler/dwarf/dwarf_test.h b/compiler/dwarf/dwarf_test.h index 230ebe3a79..3afb5eae56 100644 --- a/compiler/dwarf/dwarf_test.h +++ b/compiler/dwarf/dwarf_test.h @@ -69,7 +69,7 @@ class DwarfTest : public CommonRuntimeTest { RawSection debug_abbrev(".debug_abbrev", SHT_PROGBITS, 0, nullptr, 0, 1, 0); RawSection debug_str(".debug_str", SHT_PROGBITS, 0, nullptr, 0, 1, 0); RawSection debug_line(".debug_line", SHT_PROGBITS, 0, nullptr, 0, 1, 0); - RawSection eh_frame(".eh_frame", SHT_PROGBITS, SHF_ALLOC, nullptr, 0, kPageSize, 0); + RawSection debug_frame(".debug_frame", SHT_PROGBITS, 0, nullptr, 0, 8, 0); if (!debug_info_data_.empty()) { debug_info.SetBuffer(debug_info_data_); builder.RegisterSection(&debug_info); @@ -86,9 +86,9 @@ class DwarfTest : public CommonRuntimeTest { debug_line.SetBuffer(debug_line_data_); builder.RegisterSection(&debug_line); } - if (!eh_frame_data_.empty()) { - eh_frame.SetBuffer(eh_frame_data_); - builder.RegisterSection(&eh_frame); + if (!debug_frame_data_.empty()) { + debug_frame.SetBuffer(debug_frame_data_); + builder.RegisterSection(&debug_frame); } ScratchFile file; builder.Write(file.GetFile()); @@ -167,7 +167,7 @@ class DwarfTest : public CommonRuntimeTest { } // Buffers which are going to assembled into ELF file and passed to objdump. - std::vector<uint8_t> eh_frame_data_; + std::vector<uint8_t> debug_frame_data_; std::vector<uint8_t> debug_info_data_; std::vector<uint8_t> debug_abbrev_data_; std::vector<uint8_t> debug_str_data_; diff --git a/compiler/dwarf/headers.h b/compiler/dwarf/headers.h index 9f64766e18..ad315ee351 100644 --- a/compiler/dwarf/headers.h +++ b/compiler/dwarf/headers.h @@ -35,17 +35,18 @@ namespace dwarf { // and compilers are expected *not* to use it by default. // In particular, it is not related to machine architecture. -// Write common information entry (CIE) to .eh_frame section. +// Write common information entry (CIE) to .debug_frame or .eh_frame section. template<typename Allocator> -void WriteEhFrameCIE(bool is64bit, - ExceptionHeaderValueApplication address_type, - Reg return_address_register, - const DebugFrameOpCodeWriter<Allocator>& opcodes, - std::vector<uint8_t>* eh_frame) { - Writer<> writer(eh_frame); +void WriteDebugFrameCIE(bool is64bit, + ExceptionHeaderValueApplication address_type, + Reg return_address_register, + const DebugFrameOpCodeWriter<Allocator>& opcodes, + CFIFormat format, + std::vector<uint8_t>* debug_frame) { + Writer<> writer(debug_frame); size_t cie_header_start_ = writer.data()->size(); writer.PushUint32(0); // Length placeholder. - writer.PushUint32(0); // CIE id. + writer.PushUint32((format == DW_EH_FRAME_FORMAT) ? 0 : 0xFFFFFFFF); // CIE id. writer.PushUint8(1); // Version. writer.PushString("zR"); writer.PushUleb128(DebugFrameOpCodeWriter<Allocator>::kCodeAlignmentFactor); @@ -62,20 +63,26 @@ void WriteEhFrameCIE(bool is64bit, writer.UpdateUint32(cie_header_start_, writer.data()->size() - cie_header_start_ - 4); } -// Write frame description entry (FDE) to .eh_frame section. +// Write frame description entry (FDE) to .debug_frame or .eh_frame section. template<typename Allocator> -void WriteEhFrameFDE(bool is64bit, size_t cie_offset, - uint64_t initial_address, uint64_t address_range, - const std::vector<uint8_t, Allocator>* opcodes, - std::vector<uint8_t>* eh_frame, - std::vector<uintptr_t>* eh_frame_patches) { - Writer<> writer(eh_frame); +void WriteDebugFrameFDE(bool is64bit, size_t cie_offset, + uint64_t initial_address, uint64_t address_range, + const std::vector<uint8_t, Allocator>* opcodes, + CFIFormat format, + std::vector<uint8_t>* debug_frame, + std::vector<uintptr_t>* debug_frame_patches) { + Writer<> writer(debug_frame); size_t fde_header_start = writer.data()->size(); writer.PushUint32(0); // Length placeholder. - uint32_t cie_pointer = writer.data()->size() - cie_offset; - writer.PushUint32(cie_pointer); + if (format == DW_EH_FRAME_FORMAT) { + uint32_t cie_pointer = writer.data()->size() - cie_offset; + writer.PushUint32(cie_pointer); + } else { + uint32_t cie_pointer = cie_offset; + writer.PushUint32(cie_pointer); + } // Relocate initial_address, but not address_range (it is size). - eh_frame_patches->push_back(writer.data()->size()); + debug_frame_patches->push_back(writer.data()->size()); if (is64bit) { writer.PushUint64(initial_address); writer.PushUint64(address_range); diff --git a/compiler/elf_writer_debug.cc b/compiler/elf_writer_debug.cc index 5e9cf76788..a1aabc3605 100644 --- a/compiler/elf_writer_debug.cc +++ b/compiler/elf_writer_debug.cc @@ -29,9 +29,10 @@ namespace art { namespace dwarf { -static void WriteEhFrameCIE(InstructionSet isa, - ExceptionHeaderValueApplication addr_type, - std::vector<uint8_t>* eh_frame) { +static void WriteDebugFrameCIE(InstructionSet isa, + ExceptionHeaderValueApplication addr_type, + CFIFormat format, + std::vector<uint8_t>* eh_frame) { // Scratch registers should be marked as undefined. This tells the // debugger that its value in the previous frame is not recoverable. bool is64bit = Is64BitInstructionSet(isa); @@ -57,7 +58,8 @@ static void WriteEhFrameCIE(InstructionSet isa, } } auto return_reg = Reg::ArmCore(14); // R14(LR). - WriteEhFrameCIE(is64bit, addr_type, return_reg, opcodes, eh_frame); + WriteDebugFrameCIE(is64bit, addr_type, return_reg, + opcodes, format, eh_frame); return; } case kArm64: { @@ -80,7 +82,8 @@ static void WriteEhFrameCIE(InstructionSet isa, } } auto return_reg = Reg::Arm64Core(30); // R30(LR). - WriteEhFrameCIE(is64bit, addr_type, return_reg, opcodes, eh_frame); + WriteDebugFrameCIE(is64bit, addr_type, return_reg, + opcodes, format, eh_frame); return; } case kMips: @@ -96,7 +99,8 @@ static void WriteEhFrameCIE(InstructionSet isa, } } auto return_reg = Reg::MipsCore(31); // R31(RA). - WriteEhFrameCIE(is64bit, addr_type, return_reg, opcodes, eh_frame); + WriteDebugFrameCIE(is64bit, addr_type, return_reg, + opcodes, format, eh_frame); return; } case kX86: { @@ -122,7 +126,8 @@ static void WriteEhFrameCIE(InstructionSet isa, } } auto return_reg = Reg::X86Core(8); // R8(EIP). - WriteEhFrameCIE(is64bit, addr_type, return_reg, opcodes, eh_frame); + WriteDebugFrameCIE(is64bit, addr_type, return_reg, + opcodes, format, eh_frame); return; } case kX86_64: { @@ -148,7 +153,8 @@ static void WriteEhFrameCIE(InstructionSet isa, } } auto return_reg = Reg::X86_64Core(16); // R16(RIP). - WriteEhFrameCIE(is64bit, addr_type, return_reg, opcodes, eh_frame); + WriteDebugFrameCIE(is64bit, addr_type, return_reg, + opcodes, format, eh_frame); return; } case kNone: @@ -158,58 +164,61 @@ static void WriteEhFrameCIE(InstructionSet isa, UNREACHABLE(); } -void WriteEhFrame(const CompilerDriver* compiler, - const OatWriter* oat_writer, - ExceptionHeaderValueApplication address_type, - std::vector<uint8_t>* eh_frame, - std::vector<uintptr_t>* eh_frame_patches, - std::vector<uint8_t>* eh_frame_hdr, - std::vector<uintptr_t>* eh_frame_hdr_patches) { +void WriteCFISection(const CompilerDriver* compiler, + const OatWriter* oat_writer, + ExceptionHeaderValueApplication address_type, + CFIFormat format, + std::vector<uint8_t>* debug_frame, + std::vector<uintptr_t>* debug_frame_patches, + std::vector<uint8_t>* eh_frame_hdr, + std::vector<uintptr_t>* eh_frame_hdr_patches) { const auto& method_infos = oat_writer->GetMethodDebugInfo(); const InstructionSet isa = compiler->GetInstructionSet(); - // Write .eh_frame section. + // Write .eh_frame/.debug_frame section. std::map<uint32_t, size_t> address_to_fde_offset_map; - size_t cie_offset = eh_frame->size(); - WriteEhFrameCIE(isa, address_type, eh_frame); + size_t cie_offset = debug_frame->size(); + WriteDebugFrameCIE(isa, address_type, format, debug_frame); for (const OatWriter::DebugInfo& mi : method_infos) { if (!mi.deduped_) { // Only one FDE per unique address. const SwapVector<uint8_t>* opcodes = mi.compiled_method_->GetCFIInfo(); if (opcodes != nullptr) { - address_to_fde_offset_map.emplace(mi.low_pc_, eh_frame->size()); - WriteEhFrameFDE(Is64BitInstructionSet(isa), cie_offset, - mi.low_pc_, mi.high_pc_ - mi.low_pc_, - opcodes, eh_frame, eh_frame_patches); + address_to_fde_offset_map.emplace(mi.low_pc_, debug_frame->size()); + WriteDebugFrameFDE(Is64BitInstructionSet(isa), cie_offset, + mi.low_pc_, mi.high_pc_ - mi.low_pc_, + opcodes, format, debug_frame, debug_frame_patches); } } } - // Write .eh_frame_hdr section. - Writer<> header(eh_frame_hdr); - header.PushUint8(1); // Version. - // Encoding of .eh_frame pointer - libunwind does not honor datarel here, - // so we have to use pcrel which means relative to the pointer's location. - header.PushUint8(DW_EH_PE_pcrel | DW_EH_PE_sdata4); - // Encoding of binary search table size. - header.PushUint8(DW_EH_PE_udata4); - // Encoding of binary search table addresses - libunwind supports only this - // specific combination, which means relative to the start of .eh_frame_hdr. - header.PushUint8(DW_EH_PE_datarel | DW_EH_PE_sdata4); - // .eh_frame pointer - .eh_frame_hdr section is after .eh_frame section - const int32_t relative_eh_frame_begin = -static_cast<int32_t>(eh_frame->size()); - header.PushInt32(relative_eh_frame_begin - 4U); - // Binary search table size (number of entries). - header.PushUint32(dchecked_integral_cast<uint32_t>(address_to_fde_offset_map.size())); - // Binary search table. - for (const auto& address_to_fde_offset : address_to_fde_offset_map) { - u_int32_t code_address = address_to_fde_offset.first; - int32_t fde_address = dchecked_integral_cast<int32_t>(address_to_fde_offset.second); - eh_frame_hdr_patches->push_back(header.data()->size()); - header.PushUint32(code_address); - // We know the exact layout (eh_frame is immediately before eh_frame_hdr) - // and the data is relative to the start of the eh_frame_hdr, - // so patching isn't necessary (in contrast to the code address above). - header.PushInt32(relative_eh_frame_begin + fde_address); + if (format == DW_EH_FRAME_FORMAT) { + // Write .eh_frame_hdr section. + Writer<> header(eh_frame_hdr); + header.PushUint8(1); // Version. + // Encoding of .eh_frame pointer - libunwind does not honor datarel here, + // so we have to use pcrel which means relative to the pointer's location. + header.PushUint8(DW_EH_PE_pcrel | DW_EH_PE_sdata4); + // Encoding of binary search table size. + header.PushUint8(DW_EH_PE_udata4); + // Encoding of binary search table addresses - libunwind supports only this + // specific combination, which means relative to the start of .eh_frame_hdr. + header.PushUint8(DW_EH_PE_datarel | DW_EH_PE_sdata4); + // .eh_frame pointer - .eh_frame_hdr section is after .eh_frame section + const int32_t relative_eh_frame_begin = -static_cast<int32_t>(debug_frame->size()); + header.PushInt32(relative_eh_frame_begin - 4U); + // Binary search table size (number of entries). + header.PushUint32(dchecked_integral_cast<uint32_t>(address_to_fde_offset_map.size())); + // Binary search table. + for (const auto& address_to_fde_offset : address_to_fde_offset_map) { + u_int32_t code_address = address_to_fde_offset.first; + int32_t fde_address = dchecked_integral_cast<int32_t>(address_to_fde_offset.second); + eh_frame_hdr_patches->push_back(header.data()->size()); + header.PushUint32(code_address); + // We know the exact layout (eh_frame is immediately before eh_frame_hdr) + // and the data is relative to the start of the eh_frame_hdr, + // so patching isn't necessary (in contrast to the code address above). + header.PushInt32(relative_eh_frame_begin + fde_address); + } } } diff --git a/compiler/elf_writer_debug.h b/compiler/elf_writer_debug.h index 28d0e2cae5..69f7e0d811 100644 --- a/compiler/elf_writer_debug.h +++ b/compiler/elf_writer_debug.h @@ -25,13 +25,14 @@ namespace art { namespace dwarf { -void WriteEhFrame(const CompilerDriver* compiler, - const OatWriter* oat_writer, - ExceptionHeaderValueApplication address_type, - std::vector<uint8_t>* eh_frame, - std::vector<uintptr_t>* eh_frame_patches, - std::vector<uint8_t>* eh_frame_hdr, - std::vector<uintptr_t>* eh_frame_hdr_patches); +void WriteCFISection(const CompilerDriver* compiler, + const OatWriter* oat_writer, + ExceptionHeaderValueApplication address_type, + CFIFormat format, + std::vector<uint8_t>* debug_frame, + std::vector<uintptr_t>* debug_frame_patches, + std::vector<uint8_t>* eh_frame_hdr, + std::vector<uintptr_t>* eh_frame_hdr_patches); void WriteDebugSections(const CompilerDriver* compiler, const OatWriter* oat_writer, diff --git a/compiler/elf_writer_quick.cc b/compiler/elf_writer_quick.cc index 79f9955647..96dd7ca62d 100644 --- a/compiler/elf_writer_quick.cc +++ b/compiler/elf_writer_quick.cc @@ -37,6 +37,14 @@ namespace art { +// .eh_frame and .debug_frame are almost identical. +// Except for some minor formatting differences, the main difference +// is that .eh_frame is allocated within the running program because +// it is used by C++ exception handling (which we do not use so we +// can choose either). C++ compilers generally tend to use .eh_frame +// because if they need it sometimes, they might as well always use it. +constexpr dwarf::CFIFormat kCFIFormat = dwarf::DW_EH_FRAME_FORMAT; + template <typename ElfTypes> bool ElfWriterQuick<ElfTypes>::Create(File* elf_file, OatWriter* oat_writer, @@ -161,12 +169,17 @@ bool ElfWriterQuick<ElfTypes>::Write( using RawSection = typename ElfBuilder<ElfTypes>::RawSection; const auto* text = builder->GetText(); const bool is64bit = Is64BitInstructionSet(isa); + const int pointer_size = GetInstructionSetPointerSize(isa); RawSection eh_frame(".eh_frame", SHT_PROGBITS, SHF_ALLOC, nullptr, 0, kPageSize, 0, is64bit ? Patch<Elf_Addr, uint64_t, kPointerRelativeAddress> : Patch<Elf_Addr, uint32_t, kPointerRelativeAddress>, text); RawSection eh_frame_hdr(".eh_frame_hdr", SHT_PROGBITS, SHF_ALLOC, nullptr, 0, 4, 0, Patch<Elf_Addr, uint32_t, kSectionRelativeAddress>, text); + RawSection debug_frame(".debug_frame", SHT_PROGBITS, 0, nullptr, 0, pointer_size, 0, + is64bit ? Patch<Elf_Addr, uint64_t, kAbsoluteAddress> : + Patch<Elf_Addr, uint32_t, kAbsoluteAddress>, + text); RawSection debug_info(".debug_info", SHT_PROGBITS, 0, nullptr, 0, 1, 0, Patch<Elf_Addr, uint32_t, kAbsoluteAddress>, text); RawSection debug_abbrev(".debug_abbrev", SHT_PROGBITS, 0, nullptr, 0, 1, 0); @@ -175,12 +188,25 @@ bool ElfWriterQuick<ElfTypes>::Write( Patch<Elf_Addr, uint32_t, kAbsoluteAddress>, text); if (!oat_writer->GetMethodDebugInfo().empty()) { if (compiler_driver_->GetCompilerOptions().GetIncludeCFI()) { - dwarf::WriteEhFrame( - compiler_driver_, oat_writer, dwarf::DW_EH_PE_pcrel, - eh_frame.GetBuffer(), eh_frame.GetPatchLocations(), - eh_frame_hdr.GetBuffer(), eh_frame_hdr.GetPatchLocations()); - builder->RegisterSection(&eh_frame); - builder->RegisterSection(&eh_frame_hdr); + if (kCFIFormat == dwarf::DW_EH_FRAME_FORMAT) { + dwarf::WriteCFISection( + compiler_driver_, oat_writer, + dwarf::DW_EH_PE_pcrel, kCFIFormat, + eh_frame.GetBuffer(), eh_frame.GetPatchLocations(), + eh_frame_hdr.GetBuffer(), eh_frame_hdr.GetPatchLocations()); + builder->RegisterSection(&eh_frame); + builder->RegisterSection(&eh_frame_hdr); + } else { + DCHECK(kCFIFormat == dwarf::DW_DEBUG_FRAME_FORMAT); + dwarf::WriteCFISection( + compiler_driver_, oat_writer, + dwarf::DW_EH_PE_absptr, kCFIFormat, + debug_frame.GetBuffer(), debug_frame.GetPatchLocations(), + nullptr, nullptr); + builder->RegisterSection(&debug_frame); + *oat_writer->GetAbsolutePatchLocationsFor(".debug_frame") = + *debug_frame.GetPatchLocations(); + } } if (compiler_driver_->GetCompilerOptions().GetIncludeDebugSymbols()) { // Add methods to .symtab. diff --git a/runtime/elf_file.cc b/runtime/elf_file.cc index 0c5210dc9d..b1d933df62 100644 --- a/runtime/elf_file.cc +++ b/runtime/elf_file.cc @@ -1402,25 +1402,23 @@ typename ElfTypes::Shdr* ElfFileImpl<ElfTypes>::FindSectionByName( template <typename ElfTypes> bool ElfFileImpl<ElfTypes>::FixupDebugSections(typename std::make_signed<Elf_Off>::type base_address_delta) { - const Elf_Shdr* debug_info = FindSectionByName(".debug_info"); - const Elf_Shdr* debug_abbrev = FindSectionByName(".debug_abbrev"); - const Elf_Shdr* debug_str = FindSectionByName(".debug_str"); - const Elf_Shdr* strtab_sec = FindSectionByName(".strtab"); - const Elf_Shdr* symtab_sec = FindSectionByName(".symtab"); - - if (debug_info == nullptr || debug_abbrev == nullptr || - debug_str == nullptr || strtab_sec == nullptr || symtab_sec == nullptr) { - // Release version of ART does not generate debug info. - return true; - } if (base_address_delta == 0) { return true; } - if (!ApplyOatPatchesTo(".debug_info", base_address_delta)) { - return false; + if (FindSectionByName(".debug_frame") != nullptr) { + if (!ApplyOatPatchesTo(".debug_frame", base_address_delta)) { + return false; + } } - if (!ApplyOatPatchesTo(".debug_line", base_address_delta)) { - return false; + if (FindSectionByName(".debug_info") != nullptr) { + if (!ApplyOatPatchesTo(".debug_info", base_address_delta)) { + return false; + } + } + if (FindSectionByName(".debug_line") != nullptr) { + if (!ApplyOatPatchesTo(".debug_line", base_address_delta)) { + return false; + } } return true; } |