diff options
| author | 2017-10-30 13:14:28 +0000 | |
|---|---|---|
| committer | 2018-03-14 13:36:34 +0000 | |
| commit | a28c9980102dff32d29f9d8df172d793faa0da8a (patch) | |
| tree | 5c5057a15d33b6df6f5f45adf75bf8315759325f | |
| parent | 640df8492e21a5869d4f19e625238d0f0a802224 (diff) | |
Makes some ART gtests more robust to a non-standard environment.
Two gtests (dexdump_test and dexlist_test) used to try to write
a file in the root directory and expected this operation to fail.
However, in a non-standard environment (e.g. a testing context
where such a gtest is allowed to write in `/`), these tests would
not fail as expected. Replace these paths with more explicit ones
not depending on writing permissions.
Test: Run ART gtest dexdump_test and dexlist_test in a chroot on device.
Bug: 74730596
Bug: 34729697
Change-Id: I23537757639721133d694d5366cf05d9009f05ad
| -rw-r--r-- | dexdump/dexdump_test.cc | 2 | ||||
| -rw-r--r-- | dexlist/dexlist_test.cc | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/dexdump/dexdump_test.cc b/dexdump/dexdump_test.cc index 63e0e3f20d..3a2d38dec6 100644 --- a/dexdump/dexdump_test.cc +++ b/dexdump/dexdump_test.cc @@ -58,7 +58,7 @@ TEST_F(DexDumpTest, NoInputFileGiven) { TEST_F(DexDumpTest, CantOpenOutput) { std::string error_msg; - ASSERT_FALSE(Exec({"-o", "/joho", dex_file_}, &error_msg)) << error_msg; + ASSERT_FALSE(Exec({"-o", "/non/existent/path", dex_file_}, &error_msg)) << error_msg; } TEST_F(DexDumpTest, BadFlagCombination) { diff --git a/dexlist/dexlist_test.cc b/dexlist/dexlist_test.cc index 0b9adbddb8..68e67134cc 100644 --- a/dexlist/dexlist_test.cc +++ b/dexlist/dexlist_test.cc @@ -60,7 +60,7 @@ TEST_F(DexListTest, NoInputFileGiven) { TEST_F(DexListTest, CantOpenOutput) { std::string error_msg; - ASSERT_FALSE(Exec({"-o", "/joho", dex_file_}, &error_msg)) << error_msg; + ASSERT_FALSE(Exec({"-o", "/non/existent/path", dex_file_}, &error_msg)) << error_msg; } TEST_F(DexListTest, IllFormedMethod) { |