diff options
author | 2022-02-14 17:04:38 +0000 | |
---|---|---|
committer | 2022-02-15 14:13:01 +0000 | |
commit | 7116f80c7caaebba8d45be72d28d44a8d8a6c632 (patch) | |
tree | b6c9bc13d7d4399295d72d153525a44a04ce4a22 | |
parent | 2464218f9fa2693d66523211e085d0e3f4448c3b (diff) |
Remove `ArtField::GetOffsetDCheck()`.
Similar to the `ArtField::GetAccessFlagsDCheck()` removed in
https://android-review.googlesource.com/1982826 ,
remove the `ArtField::GetOffsetDCheck()` as the read barrier
when retrieving the declaring class may be undesirable in
some contexts and the check provides very little value.
Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing
Bug: 181943478
Change-Id: I57e1c13855a1ce4f5fb3e1fe3e5187e3f794cea7
-rw-r--r-- | runtime/art_field.cc | 4 | ||||
-rw-r--r-- | runtime/art_field.h | 5 |
2 files changed, 0 insertions, 9 deletions
diff --git a/runtime/art_field.cc b/runtime/art_field.cc index be5ac8c1c0..c248bf73a1 100644 --- a/runtime/art_field.cc +++ b/runtime/art_field.cc @@ -67,8 +67,4 @@ std::string ArtField::PrettyField(bool with_type) { return result; } -void ArtField::GetOffsetDCheck() { - CHECK(GetDeclaringClass()->IsResolved()); -} - } // namespace art diff --git a/runtime/art_field.h b/runtime/art_field.h index 04846224c4..e2a88e4185 100644 --- a/runtime/art_field.h +++ b/runtime/art_field.h @@ -87,9 +87,6 @@ class ArtField final { // Offset to field within an Object. MemberOffset GetOffset() REQUIRES_SHARED(Locks::mutator_lock_) { - if (kIsDebugBuild) { - GetOffsetDCheck(); - } return MemberOffset(offset_); } @@ -239,8 +236,6 @@ class ArtField final { ObjPtr<mirror::Class> ProxyFindSystemClass(const char* descriptor) REQUIRES_SHARED(Locks::mutator_lock_); - void GetOffsetDCheck() REQUIRES_SHARED(Locks::mutator_lock_); - GcRoot<mirror::Class> declaring_class_; uint32_t access_flags_ = 0; |