summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Stefano Cianciulli <scianciulli@google.com> 2023-09-19 14:27:38 +0000
committer Stefano Cianciulli <scianciulli@google.com> 2023-09-19 14:27:38 +0000
commit3937b95e1ecfb890fe51caf19ca565c98b602c07 (patch)
tree33ee435b2b1f3a14f3f9c0e4a3b4fa517c93f6d4
parentdec220390c8d00e65053d759b07cd60efea6a845 (diff)
Change assertions for TimeElapsedDelta in metrics_test.cc
TimeElapsedDelta is a metric that keeps track of the time elapsed (in milliseconds) since the last metrics report, which means it's almost always guaranteed to have a value bigger than 0 between two subsequent reports as in the case of MetricsTest.ArtMetricsReport (unless the test manages to run in less that 1ms each). Changing the assertion only for this particular metric fixes the intermittent failure experienced by these two tests during CI. Bug: 300070371 Test: art/test/testrunner/run_build_test_target.py -j80 art-gtest-ss-gc Change-Id: Ib4c54a9050bb82e26747d05d93d6b8785efdee2e
-rw-r--r--libartbase/base/metrics/metrics_test.cc3
1 files changed, 3 insertions, 0 deletions
diff --git a/libartbase/base/metrics/metrics_test.cc b/libartbase/base/metrics/metrics_test.cc
index f123530bd5..2a0f251eeb 100644
--- a/libartbase/base/metrics/metrics_test.cc
+++ b/libartbase/base/metrics/metrics_test.cc
@@ -203,6 +203,9 @@ TEST_F(MetricsTest, ArtMetricsReport) {
EXPECT_EQ(value, verification_time)
<< "Unexpected value for counter " << DatumName(counter_type);
found_counter_ = true;
+ } else if (counter_type == DatumId::kTimeElapsedDelta) {
+ // TimeElapsedData can be greater than 0 if the test takes more than 1ms to run
+ EXPECT_GE(value, 0u) << "Unexpected value for counter " << DatumName(counter_type);
} else {
EXPECT_EQ(value, 0u) << "Unexpected value for counter " << DatumName(counter_type);
}