summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Elliott Hughes <enh@google.com> 2025-01-13 13:28:36 -0800
committer Elliott Hughes <enh@google.com> 2025-01-14 05:46:59 -0800
commit27123e7573790ed6c7ad6c3865231385b533b00a (patch)
tree247ece602d3e50af16e4bed57ce3b6b2ec5c0b72
parent93a24263dd2a844c412d07b02756b6e6f39167bf (diff)
Add an explicit destructor for DisassemblerArm.
The std::unique_ptr destructor is constexpr in C++23, which means clang catches more attempts to delete in incomplete type than it used to. Change-Id: I8e2c953b28d5915b8dbd448e4d7cf08582d9cf0c
-rw-r--r--disassembler/disassembler_arm.cc3
-rw-r--r--disassembler/disassembler_arm.h1
2 files changed, 4 insertions, 0 deletions
diff --git a/disassembler/disassembler_arm.cc b/disassembler/disassembler_arm.cc
index c2156ca5e1..dd2a49fde9 100644
--- a/disassembler/disassembler_arm.cc
+++ b/disassembler/disassembler_arm.cc
@@ -220,6 +220,9 @@ void DisassemblerArm::CustomDisassembler::CustomDisassemblerStream::PrintLiteral
DisassemblerArm::DisassemblerArm(DisassemblerOptions* options)
: Disassembler(options), disasm_(std::make_unique<CustomDisassembler>(output_, options)) {}
+DisassemblerArm::~DisassemblerArm() {
+}
+
size_t DisassemblerArm::Dump(std::ostream& os, const uint8_t* begin) {
uintptr_t next;
// Remove the Thumb specifier bit; no effect if begin does not point to T32 code.
diff --git a/disassembler/disassembler_arm.h b/disassembler/disassembler_arm.h
index dd6621d344..7e530afc5e 100644
--- a/disassembler/disassembler_arm.h
+++ b/disassembler/disassembler_arm.h
@@ -31,6 +31,7 @@ class DisassemblerArm final : public Disassembler {
public:
explicit DisassemblerArm(DisassemblerOptions* options);
+ ~DisassemblerArm();
size_t Dump(std::ostream& os, const uint8_t* begin) override;
void Dump(std::ostream& os, const uint8_t* begin, const uint8_t* end) override;