diff options
| author | 2024-06-26 18:45:40 +0000 | |
|---|---|---|
| committer | 2024-06-28 16:43:00 +0000 | |
| commit | 1d9301bc2ec7a060ba8e8a8a0106feff4a094927 (patch) | |
| tree | 7b7cea8b2e8fa74f16df5314dfaed75ca0564766 | |
| parent | e2e951533da1ac16ecfe469aeaf087e91adb9dca (diff) | |
Remove missing nocache output of art gtests
art gtest declare an implicit output <file>-nocache which never gets
created. This is done to force the tests to run on every invocation.
This approach is not compatible with ninja's `missingoutfile=err`, which
is being enforced in https://r.android.com/3141624.
This CL drops the nocache file. art_gtest will continue to run on every
invocation because of a separate isssue - art gtests depend on
out/target/.../i18n/timestamp which is created by deapexing i18n
directly into out/target/.... One of the files of i18n is a required
dependency of icu lib, and therefore makes the transitive closure of art
gtests dirty.
Test: m out/host/linux-x86/obj/PACKAGING/art-host-gtest_intermediates/art_libdexfile_external_tests32.xml
Test: NINJA_ARGS="-n -d explain" m
out/host/linux-x86/obj/PACKAGING/art-host-gtest_intermediates/art_libdexfile_external_tests32.xml
// prints dirty, which means it will run again
Change-Id: I2f648f0bcbfc7c70c6576ff575337987ebda535c
| -rw-r--r-- | build/Android.gtest.mk | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/build/Android.gtest.mk b/build/Android.gtest.mk index 3257942c6b..03906b287d 100644 --- a/build/Android.gtest.mk +++ b/build/Android.gtest.mk @@ -249,9 +249,6 @@ $$(gtest_build_rule) : $$(gtest_exe) $$(gtest_deps) .PHONY: $$(gtest_rule) $$(gtest_rule): $$(gtest_output) -# Re-run the tests, even if nothing changed. Until the build system has a dedicated "no cache" -# option, claim to write a file that is never produced. -$$(gtest_output): .KATI_IMPLICIT_OUTPUTS := $$(gtest_output)-nocache # Limit concurrent runs. Each test itself is already highly parallel (and thus memory hungry). $$(gtest_output): .KATI_NINJA_POOL := highmem_pool $$(gtest_output): NAME := $$(gtest_rule) |