diff options
author | 2022-11-08 11:47:50 +0000 | |
---|---|---|
committer | 2022-11-09 14:37:02 +0000 | |
commit | 176362af06aa22c10c9f16886cb80dd19205e45b (patch) | |
tree | 7bc05606ae5ad7c50fcde5db1524ec5794ced555 | |
parent | 35a48ce175bacd80cae2ebb92c45a001ef25b357 (diff) |
Make compiler/utils/ symbols hidden.
Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing
Change-Id: I5e39375f16e0ff1372c35fda444a4ef33bf320bf
52 files changed, 78 insertions, 52 deletions
diff --git a/compiler/utils/arm/assembler_arm_shared.h b/compiler/utils/arm/assembler_arm_shared.h index 7464052d93..77118c88ef 100644 --- a/compiler/utils/arm/assembler_arm_shared.h +++ b/compiler/utils/arm/assembler_arm_shared.h @@ -17,7 +17,9 @@ #ifndef ART_COMPILER_UTILS_ARM_ASSEMBLER_ARM_SHARED_H_ #define ART_COMPILER_UTILS_ARM_ASSEMBLER_ARM_SHARED_H_ -namespace art { +#include "base/macros.h" + +namespace art HIDDEN { namespace arm { enum LoadOperandType { diff --git a/compiler/utils/arm/assembler_arm_vixl.cc b/compiler/utils/arm/assembler_arm_vixl.cc index 2ed065fd1e..c7ca003530 100644 --- a/compiler/utils/arm/assembler_arm_vixl.cc +++ b/compiler/utils/arm/assembler_arm_vixl.cc @@ -26,7 +26,7 @@ using namespace vixl::aarch32; // NOLINT(build/namespaces) -namespace art { +namespace art HIDDEN { namespace arm { #ifdef ___ diff --git a/compiler/utils/arm/assembler_arm_vixl.h b/compiler/utils/arm/assembler_arm_vixl.h index 5bc8a70280..f2c0b76b66 100644 --- a/compiler/utils/arm/assembler_arm_vixl.h +++ b/compiler/utils/arm/assembler_arm_vixl.h @@ -37,7 +37,7 @@ namespace vixl32 = vixl::aarch32; -namespace art { +namespace art HIDDEN { namespace arm { inline dwarf::Reg DWARFReg(vixl32::Register reg) { diff --git a/compiler/utils/arm/constants_arm.cc b/compiler/utils/arm/constants_arm.cc index b02b343b26..a927fc201a 100644 --- a/compiler/utils/arm/constants_arm.cc +++ b/compiler/utils/arm/constants_arm.cc @@ -16,7 +16,7 @@ #include "constants_arm.h" -namespace art { +namespace art HIDDEN { namespace arm { std::ostream& operator<<(std::ostream& os, const DRegister& rhs) { diff --git a/compiler/utils/arm/constants_arm.h b/compiler/utils/arm/constants_arm.h index f42fd9777b..ef6d48dd3b 100644 --- a/compiler/utils/arm/constants_arm.h +++ b/compiler/utils/arm/constants_arm.h @@ -26,8 +26,9 @@ #include "arch/arm/registers_arm.h" #include "base/casts.h" #include "base/globals.h" +#include "base/macros.h" -namespace art { +namespace art HIDDEN { namespace arm { // Defines constants and accessor classes to assemble, disassemble and diff --git a/compiler/utils/arm/jni_macro_assembler_arm_vixl.cc b/compiler/utils/arm/jni_macro_assembler_arm_vixl.cc index 2fde78365c..699df80096 100644 --- a/compiler/utils/arm/jni_macro_assembler_arm_vixl.cc +++ b/compiler/utils/arm/jni_macro_assembler_arm_vixl.cc @@ -29,7 +29,7 @@ namespace vixl32 = vixl::aarch32; using vixl::ExactAssemblyScope; using vixl::CodeBufferCheckScope; -namespace art { +namespace art HIDDEN { namespace arm { #ifdef ___ diff --git a/compiler/utils/arm/jni_macro_assembler_arm_vixl.h b/compiler/utils/arm/jni_macro_assembler_arm_vixl.h index 2b331afeed..df14d0403d 100644 --- a/compiler/utils/arm/jni_macro_assembler_arm_vixl.h +++ b/compiler/utils/arm/jni_macro_assembler_arm_vixl.h @@ -29,7 +29,7 @@ #include "utils/assembler.h" #include "utils/jni_macro_assembler.h" -namespace art { +namespace art HIDDEN { namespace arm { class ArmVIXLJNIMacroAssembler final diff --git a/compiler/utils/arm/managed_register_arm.cc b/compiler/utils/arm/managed_register_arm.cc index deff658b4f..07d50da910 100644 --- a/compiler/utils/arm/managed_register_arm.cc +++ b/compiler/utils/arm/managed_register_arm.cc @@ -18,7 +18,7 @@ #include "base/globals.h" -namespace art { +namespace art HIDDEN { namespace arm { // Returns true if this managed-register overlaps the other managed-register. diff --git a/compiler/utils/arm/managed_register_arm.h b/compiler/utils/arm/managed_register_arm.h index 6d942fa774..b3d436c10f 100644 --- a/compiler/utils/arm/managed_register_arm.h +++ b/compiler/utils/arm/managed_register_arm.h @@ -19,10 +19,11 @@ #include <android-base/logging.h> +#include "base/macros.h" #include "constants_arm.h" #include "utils/managed_register.h" -namespace art { +namespace art HIDDEN { namespace arm { // Values for register pairs. diff --git a/compiler/utils/arm/managed_register_arm_test.cc b/compiler/utils/arm/managed_register_arm_test.cc index 6f440a7c81..60f6090edd 100644 --- a/compiler/utils/arm/managed_register_arm_test.cc +++ b/compiler/utils/arm/managed_register_arm_test.cc @@ -16,9 +16,10 @@ #include "managed_register_arm.h" #include "base/globals.h" +#include "base/macros.h" #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { namespace arm { TEST(ArmManagedRegister, NoRegister) { diff --git a/compiler/utils/arm64/assembler_arm64.cc b/compiler/utils/arm64/assembler_arm64.cc index b71b00b124..cc50883350 100644 --- a/compiler/utils/arm64/assembler_arm64.cc +++ b/compiler/utils/arm64/assembler_arm64.cc @@ -24,7 +24,7 @@ using namespace vixl::aarch64; // NOLINT(build/namespaces) -namespace art { +namespace art HIDDEN { namespace arm64 { #ifdef ___ diff --git a/compiler/utils/arm64/assembler_arm64.h b/compiler/utils/arm64/assembler_arm64.h index b49a13a067..62f807f998 100644 --- a/compiler/utils/arm64/assembler_arm64.h +++ b/compiler/utils/arm64/assembler_arm64.h @@ -38,7 +38,7 @@ #include "aarch64/macro-assembler-aarch64.h" #pragma GCC diagnostic pop -namespace art { +namespace art HIDDEN { class Arm64InstructionSetFeatures; diff --git a/compiler/utils/arm64/jni_macro_assembler_arm64.cc b/compiler/utils/arm64/jni_macro_assembler_arm64.cc index 88a1b37205..27d275fe61 100644 --- a/compiler/utils/arm64/jni_macro_assembler_arm64.cc +++ b/compiler/utils/arm64/jni_macro_assembler_arm64.cc @@ -24,7 +24,7 @@ using namespace vixl::aarch64; // NOLINT(build/namespaces) -namespace art { +namespace art HIDDEN { namespace arm64 { #ifdef ___ diff --git a/compiler/utils/arm64/jni_macro_assembler_arm64.h b/compiler/utils/arm64/jni_macro_assembler_arm64.h index 762fe680be..3f6a4fb30d 100644 --- a/compiler/utils/arm64/jni_macro_assembler_arm64.h +++ b/compiler/utils/arm64/jni_macro_assembler_arm64.h @@ -37,7 +37,7 @@ #include "aarch64/macro-assembler-aarch64.h" #pragma GCC diagnostic pop -namespace art { +namespace art HIDDEN { namespace arm64 { class Arm64JNIMacroAssembler final : public JNIMacroAssemblerFwd<Arm64Assembler, PointerSize::k64> { diff --git a/compiler/utils/arm64/managed_register_arm64.cc b/compiler/utils/arm64/managed_register_arm64.cc index 5632265646..74a35452db 100644 --- a/compiler/utils/arm64/managed_register_arm64.cc +++ b/compiler/utils/arm64/managed_register_arm64.cc @@ -17,7 +17,7 @@ #include "managed_register_arm64.h" #include "base/globals.h" -namespace art { +namespace art HIDDEN { namespace arm64 { // TODO: Define convention diff --git a/compiler/utils/arm64/managed_register_arm64.h b/compiler/utils/arm64/managed_register_arm64.h index 8a06f631a1..7e8c976b23 100644 --- a/compiler/utils/arm64/managed_register_arm64.h +++ b/compiler/utils/arm64/managed_register_arm64.h @@ -20,9 +20,10 @@ #include <android-base/logging.h> #include "arch/arm64/registers_arm64.h" +#include "base/macros.h" #include "utils/managed_register.h" -namespace art { +namespace art HIDDEN { namespace arm64 { const int kNumberOfXRegIds = kNumberOfXRegisters; diff --git a/compiler/utils/arm64/managed_register_arm64_test.cc b/compiler/utils/arm64/managed_register_arm64_test.cc index d151ac99e7..f250360639 100644 --- a/compiler/utils/arm64/managed_register_arm64_test.cc +++ b/compiler/utils/arm64/managed_register_arm64_test.cc @@ -18,9 +18,10 @@ #include "assembler_arm64.h" #include "base/globals.h" +#include "base/macros.h" #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { namespace arm64 { TEST(Arm64ManagedRegister, NoRegister) { diff --git a/compiler/utils/assembler.cc b/compiler/utils/assembler.cc index d1d2a3d556..b82f0dc4b4 100644 --- a/compiler/utils/assembler.cc +++ b/compiler/utils/assembler.cc @@ -23,7 +23,7 @@ #include "base/globals.h" #include "base/memory_region.h" -namespace art { +namespace art HIDDEN { AssemblerBuffer::AssemblerBuffer(ArenaAllocator* allocator) : allocator_(allocator) { diff --git a/compiler/utils/assembler.h b/compiler/utils/assembler.h index 4b4fb14df6..13a5d9fd01 100644 --- a/compiler/utils/assembler.h +++ b/compiler/utils/assembler.h @@ -37,7 +37,7 @@ #include "x86/constants_x86.h" #include "x86_64/constants_x86_64.h" -namespace art { +namespace art HIDDEN { class Assembler; class AssemblerBuffer; diff --git a/compiler/utils/assembler_test.h b/compiler/utils/assembler_test.h index 09146ea428..d03e5a7abc 100644 --- a/compiler/utils/assembler_test.h +++ b/compiler/utils/assembler_test.h @@ -26,11 +26,12 @@ #include <fstream> #include <iterator> +#include "base/macros.h" #include "base/malloc_arena_pool.h" #include "assembler_test_base.h" #include "common_runtime_test.h" // For ScratchFile -namespace art { +namespace art HIDDEN { // Helper for a constexpr string length. constexpr size_t ConstexprStrLen(char const* str, size_t count = 0) { diff --git a/compiler/utils/assembler_test_base.h b/compiler/utils/assembler_test_base.h index de19d660a7..a342d9a46a 100644 --- a/compiler/utils/assembler_test_base.h +++ b/compiler/utils/assembler_test_base.h @@ -26,6 +26,7 @@ #include "android-base/strings.h" +#include "base/macros.h" #include "base/os.h" #include "base/utils.h" #include "common_runtime_test.h" // For ScratchDir. @@ -34,7 +35,7 @@ #include "exec_utils.h" #include "stream/file_output_stream.h" -namespace art { +namespace art HIDDEN { // If you want to take a look at the differences between the ART assembler and clang, // set this flag to true. The disassembled files will then remain in the tmp directory. diff --git a/compiler/utils/assembler_thumb_test.cc b/compiler/utils/assembler_thumb_test.cc index f867a052a2..7d0842629b 100644 --- a/compiler/utils/assembler_thumb_test.cc +++ b/compiler/utils/assembler_thumb_test.cc @@ -30,10 +30,11 @@ #include "utils/assembler_test_base.h" #include "base/hex_dump.h" +#include "base/macros.h" #include "base/malloc_arena_pool.h" #include "common_runtime_test.h" -namespace art { +namespace art HIDDEN { namespace arm { // Include results file (generated manually) diff --git a/compiler/utils/atomic_dex_ref_map-inl.h b/compiler/utils/atomic_dex_ref_map-inl.h index 377b7fe352..5f68a7c701 100644 --- a/compiler/utils/atomic_dex_ref_map-inl.h +++ b/compiler/utils/atomic_dex_ref_map-inl.h @@ -21,12 +21,13 @@ #include <type_traits> +#include "base/macros.h" #include "dex/class_reference.h" #include "dex/dex_file-inl.h" #include "dex/method_reference.h" #include "dex/type_reference.h" -namespace art { +namespace art HIDDEN { template <typename DexFileReferenceType, typename Value> inline size_t AtomicDexRefMap<DexFileReferenceType, Value>::NumberOfDexIndices( diff --git a/compiler/utils/atomic_dex_ref_map.h b/compiler/utils/atomic_dex_ref_map.h index a8c285f765..b10fef50c5 100644 --- a/compiler/utils/atomic_dex_ref_map.h +++ b/compiler/utils/atomic_dex_ref_map.h @@ -19,10 +19,11 @@ #include "base/atomic.h" #include "base/dchecked_vector.h" +#include "base/macros.h" #include "base/safe_map.h" #include "dex/dex_file_reference.h" -namespace art { +namespace art HIDDEN { class DexFile; diff --git a/compiler/utils/atomic_dex_ref_map_test.cc b/compiler/utils/atomic_dex_ref_map_test.cc index 864531ed91..329735b796 100644 --- a/compiler/utils/atomic_dex_ref_map_test.cc +++ b/compiler/utils/atomic_dex_ref_map_test.cc @@ -18,12 +18,13 @@ #include <memory> +#include "base/macros.h" #include "common_runtime_test.h" #include "dex/dex_file-inl.h" #include "dex/method_reference.h" #include "scoped_thread_state_change-inl.h" -namespace art { +namespace art HIDDEN { class AtomicDexRefMapTest : public CommonRuntimeTest {}; diff --git a/compiler/utils/dedupe_set-inl.h b/compiler/utils/dedupe_set-inl.h index d4a9cc829b..db744c53f7 100644 --- a/compiler/utils/dedupe_set-inl.h +++ b/compiler/utils/dedupe_set-inl.h @@ -27,11 +27,12 @@ #include "android-base/stringprintf.h" #include "base/hash_set.h" +#include "base/macros.h" #include "base/mutex.h" #include "base/stl_util.h" #include "base/time_utils.h" -namespace art { +namespace art HIDDEN { template <typename InKey, typename StoreKey, diff --git a/compiler/utils/dedupe_set.h b/compiler/utils/dedupe_set.h index a1ba208d2c..42db8e3ca0 100644 --- a/compiler/utils/dedupe_set.h +++ b/compiler/utils/dedupe_set.h @@ -23,7 +23,7 @@ #include "base/macros.h" -namespace art { +namespace art HIDDEN { class Thread; diff --git a/compiler/utils/dedupe_set_test.cc b/compiler/utils/dedupe_set_test.cc index b390508ed4..89385e7c82 100644 --- a/compiler/utils/dedupe_set_test.cc +++ b/compiler/utils/dedupe_set_test.cc @@ -21,11 +21,12 @@ #include <vector> #include "base/array_ref.h" +#include "base/macros.h" #include "dedupe_set-inl.h" #include "gtest/gtest.h" #include "thread-current-inl.h" -namespace art { +namespace art HIDDEN { class DedupeSetTestHashFunc { public: diff --git a/compiler/utils/jni_macro_assembler.cc b/compiler/utils/jni_macro_assembler.cc index d6d49f8faa..f11b48d8ca 100644 --- a/compiler/utils/jni_macro_assembler.cc +++ b/compiler/utils/jni_macro_assembler.cc @@ -35,7 +35,7 @@ #include "base/globals.h" #include "base/memory_region.h" -namespace art { +namespace art HIDDEN { using MacroAsm32UniquePtr = std::unique_ptr<JNIMacroAssembler<PointerSize::k32>>; diff --git a/compiler/utils/jni_macro_assembler.h b/compiler/utils/jni_macro_assembler.h index a91176c785..79dd987081 100644 --- a/compiler/utils/jni_macro_assembler.h +++ b/compiler/utils/jni_macro_assembler.h @@ -30,7 +30,7 @@ #include "managed_register.h" #include "offsets.h" -namespace art { +namespace art HIDDEN { class ArenaAllocator; class DebugFrameOpCodeWriterForAssembler; diff --git a/compiler/utils/jni_macro_assembler_test.h b/compiler/utils/jni_macro_assembler_test.h index 62e81914ac..ac8e7d3010 100644 --- a/compiler/utils/jni_macro_assembler_test.h +++ b/compiler/utils/jni_macro_assembler_test.h @@ -20,6 +20,7 @@ #include "jni_macro_assembler.h" #include "assembler_test_base.h" +#include "base/macros.h" #include "base/malloc_arena_pool.h" #include "common_runtime_test.h" // For ScratchFile @@ -30,7 +31,7 @@ #include <fstream> #include <iterator> -namespace art { +namespace art HIDDEN { template<typename Ass> class JNIMacroAssemblerTest : public AssemblerTestBase { diff --git a/compiler/utils/label.h b/compiler/utils/label.h index 282500b1b7..0368d90a26 100644 --- a/compiler/utils/label.h +++ b/compiler/utils/label.h @@ -20,7 +20,9 @@ #include <android-base/logging.h> #include <android-base/macros.h> -namespace art { +#include "base/macros.h" + +namespace art HIDDEN { class Assembler; class AssemblerBuffer; diff --git a/compiler/utils/managed_register.h b/compiler/utils/managed_register.h index a3b33ba94d..72acbd5a27 100644 --- a/compiler/utils/managed_register.h +++ b/compiler/utils/managed_register.h @@ -20,9 +20,10 @@ #include <type_traits> #include <vector> +#include "base/macros.h" #include "base/value_object.h" -namespace art { +namespace art HIDDEN { namespace arm { class ArmManagedRegister; diff --git a/compiler/utils/stack_checks.h b/compiler/utils/stack_checks.h index c348f2c8ee..d0fff73df3 100644 --- a/compiler/utils/stack_checks.h +++ b/compiler/utils/stack_checks.h @@ -18,8 +18,9 @@ #define ART_COMPILER_UTILS_STACK_CHECKS_H_ #include "arch/instruction_set.h" +#include "base/macros.h" -namespace art { +namespace art HIDDEN { // Size of a frame that we definitely consider large. Anything larger than this should // definitely get a stack overflow check. diff --git a/compiler/utils/x86/assembler_x86.cc b/compiler/utils/x86/assembler_x86.cc index 861b27e6af..a6b90114b2 100644 --- a/compiler/utils/x86/assembler_x86.cc +++ b/compiler/utils/x86/assembler_x86.cc @@ -21,7 +21,7 @@ #include "entrypoints/quick/quick_entrypoints.h" #include "thread.h" -namespace art { +namespace art HIDDEN { namespace x86 { std::ostream& operator<<(std::ostream& os, const XmmRegister& reg) { diff --git a/compiler/utils/x86/assembler_x86.h b/compiler/utils/x86/assembler_x86.h index c346ba9235..0f7854dc5c 100644 --- a/compiler/utils/x86/assembler_x86.h +++ b/compiler/utils/x86/assembler_x86.h @@ -32,7 +32,7 @@ #include "offsets.h" #include "utils/assembler.h" -namespace art { +namespace art HIDDEN { namespace x86 { class Immediate : public ValueObject { diff --git a/compiler/utils/x86/assembler_x86_test.cc b/compiler/utils/x86/assembler_x86_test.cc index 89c73c0ade..5da6f04402 100644 --- a/compiler/utils/x86/assembler_x86_test.cc +++ b/compiler/utils/x86/assembler_x86_test.cc @@ -17,11 +17,12 @@ #include "assembler_x86.h" #include "base/arena_allocator.h" +#include "base/macros.h" #include "base/malloc_arena_pool.h" #include "base/stl_util.h" #include "utils/assembler_test.h" -namespace art { +namespace art HIDDEN { TEST(AssemblerX86, CreateBuffer) { MallocArenaPool pool; diff --git a/compiler/utils/x86/constants_x86.h b/compiler/utils/x86/constants_x86.h index 477b915bb9..0c0a7d4133 100644 --- a/compiler/utils/x86/constants_x86.h +++ b/compiler/utils/x86/constants_x86.h @@ -25,7 +25,7 @@ #include "base/globals.h" #include "base/macros.h" -namespace art { +namespace art HIDDEN { namespace x86 { enum ByteRegister { diff --git a/compiler/utils/x86/jni_macro_assembler_x86.cc b/compiler/utils/x86/jni_macro_assembler_x86.cc index a1c874ec09..7bb167cdf4 100644 --- a/compiler/utils/x86/jni_macro_assembler_x86.cc +++ b/compiler/utils/x86/jni_macro_assembler_x86.cc @@ -22,7 +22,7 @@ #include "thread.h" #include "utils/assembler.h" -namespace art { +namespace art HIDDEN { namespace x86 { static Register GetScratchRegister() { diff --git a/compiler/utils/x86/jni_macro_assembler_x86.h b/compiler/utils/x86/jni_macro_assembler_x86.h index 1a1bc13968..eba4b99b8d 100644 --- a/compiler/utils/x86/jni_macro_assembler_x86.h +++ b/compiler/utils/x86/jni_macro_assembler_x86.h @@ -27,7 +27,7 @@ #include "offsets.h" #include "utils/jni_macro_assembler.h" -namespace art { +namespace art HIDDEN { namespace x86 { class X86JNIMacroLabel; diff --git a/compiler/utils/x86/managed_register_x86.cc b/compiler/utils/x86/managed_register_x86.cc index cc7cedf93e..bef948056f 100644 --- a/compiler/utils/x86/managed_register_x86.cc +++ b/compiler/utils/x86/managed_register_x86.cc @@ -18,7 +18,7 @@ #include "base/globals.h" -namespace art { +namespace art HIDDEN { namespace x86 { // Define register pairs. diff --git a/compiler/utils/x86/managed_register_x86.h b/compiler/utils/x86/managed_register_x86.h index 27555bfd32..def4f68b27 100644 --- a/compiler/utils/x86/managed_register_x86.h +++ b/compiler/utils/x86/managed_register_x86.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_UTILS_X86_MANAGED_REGISTER_X86_H_ #define ART_COMPILER_UTILS_X86_MANAGED_REGISTER_X86_H_ +#include "base/macros.h" #include "constants_x86.h" #include "utils/managed_register.h" -namespace art { +namespace art HIDDEN { namespace x86 { // Values for register pairs. diff --git a/compiler/utils/x86/managed_register_x86_test.cc b/compiler/utils/x86/managed_register_x86_test.cc index 28af5313c7..9f5e1970ac 100644 --- a/compiler/utils/x86/managed_register_x86_test.cc +++ b/compiler/utils/x86/managed_register_x86_test.cc @@ -17,9 +17,10 @@ #include "managed_register_x86.h" #include "base/globals.h" +#include "base/macros.h" #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { namespace x86 { TEST(X86ManagedRegister, NoRegister) { diff --git a/compiler/utils/x86_64/assembler_x86_64.cc b/compiler/utils/x86_64/assembler_x86_64.cc index 21a44810ba..3fdf05bed9 100644 --- a/compiler/utils/x86_64/assembler_x86_64.cc +++ b/compiler/utils/x86_64/assembler_x86_64.cc @@ -21,7 +21,7 @@ #include "entrypoints/quick/quick_entrypoints.h" #include "thread.h" -namespace art { +namespace art HIDDEN { namespace x86_64 { std::ostream& operator<<(std::ostream& os, const CpuRegister& reg) { diff --git a/compiler/utils/x86_64/assembler_x86_64.h b/compiler/utils/x86_64/assembler_x86_64.h index ea944c200e..9402fe3b44 100644 --- a/compiler/utils/x86_64/assembler_x86_64.h +++ b/compiler/utils/x86_64/assembler_x86_64.h @@ -32,7 +32,7 @@ #include "utils/assembler.h" #include "utils/jni_macro_assembler.h" -namespace art { +namespace art HIDDEN { namespace x86_64 { // Encodes an immediate value for operands. diff --git a/compiler/utils/x86_64/assembler_x86_64_test.cc b/compiler/utils/x86_64/assembler_x86_64_test.cc index f7e890d112..a7c206afaa 100644 --- a/compiler/utils/x86_64/assembler_x86_64_test.cc +++ b/compiler/utils/x86_64/assembler_x86_64_test.cc @@ -21,13 +21,14 @@ #include <random> #include "base/bit_utils.h" +#include "base/macros.h" #include "base/malloc_arena_pool.h" #include "base/stl_util.h" #include "jni_macro_assembler_x86_64.h" #include "utils/assembler_test.h" #include "utils/jni_macro_assembler_test.h" -namespace art { +namespace art HIDDEN { TEST(AssemblerX86_64, CreateBuffer) { MallocArenaPool pool; diff --git a/compiler/utils/x86_64/constants_x86_64.h b/compiler/utils/x86_64/constants_x86_64.h index 301c8fc09b..52ac987766 100644 --- a/compiler/utils/x86_64/constants_x86_64.h +++ b/compiler/utils/x86_64/constants_x86_64.h @@ -25,7 +25,7 @@ #include "base/globals.h" #include "base/macros.h" -namespace art { +namespace art HIDDEN { namespace x86_64 { class CpuRegister { diff --git a/compiler/utils/x86_64/jni_macro_assembler_x86_64.cc b/compiler/utils/x86_64/jni_macro_assembler_x86_64.cc index 7710dfb359..044027aaca 100644 --- a/compiler/utils/x86_64/jni_macro_assembler_x86_64.cc +++ b/compiler/utils/x86_64/jni_macro_assembler_x86_64.cc @@ -22,7 +22,7 @@ #include "lock_word.h" #include "thread.h" -namespace art { +namespace art HIDDEN { namespace x86_64 { static dwarf::Reg DWARFReg(Register reg) { diff --git a/compiler/utils/x86_64/jni_macro_assembler_x86_64.h b/compiler/utils/x86_64/jni_macro_assembler_x86_64.h index 827e1cc0ed..3308c7ebd3 100644 --- a/compiler/utils/x86_64/jni_macro_assembler_x86_64.h +++ b/compiler/utils/x86_64/jni_macro_assembler_x86_64.h @@ -28,7 +28,7 @@ #include "utils/assembler.h" #include "utils/jni_macro_assembler.h" -namespace art { +namespace art HIDDEN { namespace x86_64 { class X86_64JNIMacroAssembler final : public JNIMacroAssemblerFwd<X86_64Assembler, diff --git a/compiler/utils/x86_64/managed_register_x86_64.cc b/compiler/utils/x86_64/managed_register_x86_64.cc index c0eec9d86c..75ff8aaf1d 100644 --- a/compiler/utils/x86_64/managed_register_x86_64.cc +++ b/compiler/utils/x86_64/managed_register_x86_64.cc @@ -18,7 +18,7 @@ #include "base/globals.h" -namespace art { +namespace art HIDDEN { namespace x86_64 { // Define register pairs. diff --git a/compiler/utils/x86_64/managed_register_x86_64.h b/compiler/utils/x86_64/managed_register_x86_64.h index 62c0e373a7..7a1be0bd8f 100644 --- a/compiler/utils/x86_64/managed_register_x86_64.h +++ b/compiler/utils/x86_64/managed_register_x86_64.h @@ -17,10 +17,11 @@ #ifndef ART_COMPILER_UTILS_X86_64_MANAGED_REGISTER_X86_64_H_ #define ART_COMPILER_UTILS_X86_64_MANAGED_REGISTER_X86_64_H_ +#include "base/macros.h" #include "constants_x86_64.h" #include "utils/managed_register.h" -namespace art { +namespace art HIDDEN { namespace x86_64 { // Values for register pairs. diff --git a/compiler/utils/x86_64/managed_register_x86_64_test.cc b/compiler/utils/x86_64/managed_register_x86_64_test.cc index 46a405ffaf..048268bf9b 100644 --- a/compiler/utils/x86_64/managed_register_x86_64_test.cc +++ b/compiler/utils/x86_64/managed_register_x86_64_test.cc @@ -16,9 +16,10 @@ #include "managed_register_x86_64.h" #include "base/globals.h" +#include "base/macros.h" #include "gtest/gtest.h" -namespace art { +namespace art HIDDEN { namespace x86_64 { TEST(X86_64ManagedRegister, NoRegister) { |