diff options
| author | 2025-01-29 11:12:28 -0800 | |
|---|---|---|
| committer | 2025-01-29 11:12:28 -0800 | |
| commit | ee5d81737809fa7a316c2ccf5819a5e7b567b3dd (patch) | |
| tree | 51b863d80b80844b520de320aa89e1009fdc21f1 | |
| parent | ee1cf6516dff6d4b4884e32562e093ab38288f7e (diff) | |
| parent | da74602992ff6b4eb5284374f18de1c748967783 (diff) | |
Remove old workaround in RecordPcInfo am: 0f800d14c6 am: da74602992
Original change: https://android-review.googlesource.com/c/platform/art/+/3457761
Change-Id: I6d8c3f5c7a21f1c41d77f7ecc300cd2f37cb7d16
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
| -rw-r--r-- | compiler/optimizing/code_generator.cc | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/compiler/optimizing/code_generator.cc b/compiler/optimizing/code_generator.cc index c4866146b4..e84cfcbe80 100644 --- a/compiler/optimizing/code_generator.cc +++ b/compiler/optimizing/code_generator.cc @@ -1167,26 +1167,6 @@ void CodeGenerator::RecordPcInfo(HInstruction* instruction, // the regular case, we retrieve the dex_pc from the instruction's environment. DCHECK_IMPLIES(native_debug_info, GetCompilerOptions().GetNativeDebuggable()); DCHECK_IMPLIES(!native_debug_info, instruction->HasEnvironment()) << *instruction; - // The code generated for some type conversions - // may call the runtime, thus normally requiring a subsequent - // call to this method. However, the method verifier does not - // produce PC information for certain instructions, which are - // considered "atomic" (they cannot join a GC). - // Therefore we do not currently record PC information for such - // instructions. As this may change later, we added this special - // case so that code generators may nevertheless call - // CodeGenerator::RecordPcInfo without triggering an error in - // CodeGenerator::BuildNativeGCMap ("Missing ref for dex pc 0x") - // thereafter. - if (instruction->IsTypeConversion()) { - return; - } - if (instruction->IsRem()) { - DataType::Type type = instruction->AsRem()->GetResultType(); - if ((type == DataType::Type::kFloat32) || (type == DataType::Type::kFloat64)) { - return; - } - } LocationSummary* locations = instruction->GetLocations(); uint32_t register_mask = locations->GetRegisterMask(); |