summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author David Srbecky <dsrbecky@google.com> 2018-01-12 15:47:59 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2018-01-12 15:47:59 +0000
commitd97a2d17924bc4b19674c6ec7dd494a4dca3d70e (patch)
tree9065f265af4eca6b3921e1d498e947747eb56fe2
parent3837c878f6e846eff19640298c3500d57bc5c69e (diff)
parent71d3c88c37b236d197d1fc9016282505bc24bc2c (diff)
Merge "Allow mmap reuse in lower 4GB"
-rw-r--r--runtime/mem_map.cc3
-rw-r--r--runtime/vdex_file.cc5
2 files changed, 0 insertions, 8 deletions
diff --git a/runtime/mem_map.cc b/runtime/mem_map.cc
index 8abf8a6003..55e9c390cd 100644
--- a/runtime/mem_map.cc
+++ b/runtime/mem_map.cc
@@ -927,9 +927,6 @@ void* MemMap::MapInternal(void* addr,
UNUSED(low_4gb);
#endif
DCHECK_ALIGNED(length, kPageSize);
- if (low_4gb) {
- DCHECK_EQ(flags & MAP_FIXED, 0);
- }
// TODO:
// A page allocator would be a useful abstraction here, as
// 1) It is doubtful that MAP_32BIT on x86_64 is doing the right job for us
diff --git a/runtime/vdex_file.cc b/runtime/vdex_file.cc
index 3ac4aa24c9..c536054883 100644
--- a/runtime/vdex_file.cc
+++ b/runtime/vdex_file.cc
@@ -110,11 +110,6 @@ std::unique_ptr<VdexFile> VdexFile::OpenAtAddress(uint8_t* mmap_addr,
bool low_4gb,
bool unquicken,
std::string* error_msg) {
- if (low_4gb) {
- LOG(WARNING) << "Can not mmap vdex in low 4GB"; // TODO: Implement in MemMap.
- mmap_addr = nullptr;
- mmap_reuse = false;
- }
if (mmap_addr != nullptr && mmap_size < vdex_length) {
LOG(WARNING) << "Insufficient pre-allocated space to mmap vdex.";
mmap_addr = nullptr;