summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Mathieu Chartier <mathieuc@google.com> 2014-08-06 22:04:11 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2014-08-04 23:48:55 +0000
commitcf73835af1421b3346a180c4eb2236d373bf2f2f (patch)
treee82042f76b074def90710b0b7e22152c9371e33a
parent0f56c9cae0f570483a1d420172377b1754331025 (diff)
parentb9dbab627bdc3570d5f41cfd6de80ff3b70e1783 (diff)
Merge "Revert "Temporary fix for bad LIR generation in GenInlinedGet.""
-rwxr-xr-xcompiler/dex/quick/gen_invoke.cc8
1 files changed, 1 insertions, 7 deletions
diff --git a/compiler/dex/quick/gen_invoke.cc b/compiler/dex/quick/gen_invoke.cc
index e70b0c5a48..8e7f6a6c58 100755
--- a/compiler/dex/quick/gen_invoke.cc
+++ b/compiler/dex/quick/gen_invoke.cc
@@ -1166,14 +1166,8 @@ bool Mir2Lir::GenInlinedGet(CallInfo* info) {
}
if (use_direct_type_ptr) {
LoadConstant(reg_class, direct_type_ptr);
- } else if (cu_->dex_file == old_dex) {
- // TODO: Bug 16656190 If cu_->dex_file != old_dex the patching could retrieve the wrong class
- // since the load class is indexed only by the type_idx. We should include which dex file a
- // class is from in the LoadClassType LIR.
- LoadClassType(type_idx, kArg1);
} else {
- cu_->dex_file = old_dex;
- return false;
+ LoadClassType(type_idx, kArg1);
}
cu_->dex_file = old_dex;