summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Roland Levillain <rpl@google.com> 2021-09-17 12:15:22 +0100
committer Roland Levillain <rpl@google.com> 2021-09-17 14:22:59 +0000
commit96d8f4f3cf969ba8ab61abfb813b47969fe73bcc (patch)
treeb79dc3edcec5a949b3ea9f64d0e4485211fb10e9
parent3027c60ed7794c899044c2d855ab3af57a8ca8a2 (diff)
Fix two incorrect test conditions in `libartbase/base/flags_test.cc`.
Fix conditions in the following `art_libartbase_tests` tests, which used to be inverted: - `FlagsTestsWithCmdLine.FlagsTestsGetValueServerSetting` - `FlagsTestsCmdLineOnly.CmdlineOnlyFlags` Test: atest art_standalone_libartbase_tests Test: Run `art_libartbase_tests` with original chroot-based harness Bug: 190150217 Change-Id: Id3d1aa74fd435c82b6806af5a0b9b5eab8371dfb
-rw-r--r--libartbase/base/flags_test.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/libartbase/base/flags_test.cc b/libartbase/base/flags_test.cc
index b41df46e86..7cc2890232 100644
--- a/libartbase/base/flags_test.cc
+++ b/libartbase/base/flags_test.cc
@@ -174,7 +174,7 @@ TEST_F(FlagsTestsWithCmdLine, FlagsTestsGetValueServerSetting) {
return;
}
- if (android::base::SetProperty(test_flag_->ServerSetting(), "3")) {
+ if (!android::base::SetProperty(test_flag_->ServerSetting(), "3")) {
LOG(ERROR) << "Release does not support property setting, skipping test: "
<< test_flag_->ServerSetting();
return;
@@ -228,7 +228,7 @@ TEST_F(FlagsTestsCmdLineOnly, CmdlineOnlyFlags) {
return;
}
- if (android::base::SetProperty(test_flag_->ServerSetting(), "3")) {
+ if (!android::base::SetProperty(test_flag_->ServerSetting(), "3")) {
LOG(ERROR) << "Release does not support property setting, skipping test: "
<< test_flag_->ServerSetting();
return;