diff options
| author | 2025-01-03 00:21:04 -0800 | |
|---|---|---|
| committer | 2025-01-03 00:21:04 -0800 | |
| commit | 75690c0fa6a9ebfe39ae160f90c265b97471964e (patch) | |
| tree | 3040266b61bd5b66150c7fcbd43d4be19856d195 | |
| parent | d3961d1d458a28e4e097816a57409ab495395fa3 (diff) | |
| parent | 82efdc3c6b9a1d70fa9e290f7c3a70778a8e816a (diff) | |
Rename `GetBootImageVarHandleField()`, drop "Boot". am: 82efdc3c6b
Original change: https://android-review.googlesource.com/c/platform/art/+/3431232
Change-Id: Id911a97219e90379d0ee32692f492b0310517e7b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
| -rw-r--r-- | compiler/optimizing/intrinsics.h | 2 | ||||
| -rw-r--r-- | compiler/optimizing/intrinsics_arm64.cc | 2 | ||||
| -rw-r--r-- | compiler/optimizing/intrinsics_arm_vixl.cc | 2 | ||||
| -rw-r--r-- | compiler/optimizing/intrinsics_riscv64.cc | 2 | ||||
| -rw-r--r-- | compiler/optimizing/intrinsics_utils.h | 2 | ||||
| -rw-r--r-- | compiler/optimizing/intrinsics_x86_64.cc | 2 |
6 files changed, 6 insertions, 6 deletions
diff --git a/compiler/optimizing/intrinsics.h b/compiler/optimizing/intrinsics.h index 7a27b2506b..4f164e10c6 100644 --- a/compiler/optimizing/intrinsics.h +++ b/compiler/optimizing/intrinsics.h @@ -270,7 +270,7 @@ class VarHandleOptimizations : public IntrinsicOptimizations { INTRINSIC_OPTIMIZATION(DoNotIntrinsify, 0); // One of the checks is statically known to fail. INTRINSIC_OPTIMIZATION(SkipObjectNullCheck, 1); // Not applicable for static fields. - // Use known `VarHandle` from the boot image. To apply this optimization, the following + // Use known `VarHandle` from the boot/app image. To apply this optimization, the following // `VarHandle` checks must pass based on static analysis: // - `VarHandle` type check (must match the coordinate count), // - access mode check, diff --git a/compiler/optimizing/intrinsics_arm64.cc b/compiler/optimizing/intrinsics_arm64.cc index d12b2f7981..a4463cb248 100644 --- a/compiler/optimizing/intrinsics_arm64.cc +++ b/compiler/optimizing/intrinsics_arm64.cc @@ -4863,7 +4863,7 @@ static void GenerateVarHandleTarget(HInvoke* invoke, if (expected_coordinates_count <= 1u) { if (VarHandleOptimizations(invoke).GetUseKnownImageVarHandle()) { ScopedObjectAccess soa(Thread::Current()); - ArtField* target_field = GetBootImageVarHandleField(invoke); + ArtField* target_field = GetImageVarHandleField(invoke); if (expected_coordinates_count == 0u) { ObjPtr<mirror::Class> declaring_class = target_field->GetDeclaringClass(); if (Runtime::Current()->GetHeap()->ObjectIsInBootImageSpace(declaring_class)) { diff --git a/compiler/optimizing/intrinsics_arm_vixl.cc b/compiler/optimizing/intrinsics_arm_vixl.cc index 04793b4f66..db7457a68b 100644 --- a/compiler/optimizing/intrinsics_arm_vixl.cc +++ b/compiler/optimizing/intrinsics_arm_vixl.cc @@ -4597,7 +4597,7 @@ static void GenerateVarHandleTarget(HInvoke* invoke, if (expected_coordinates_count <= 1u) { if (VarHandleOptimizations(invoke).GetUseKnownImageVarHandle()) { ScopedObjectAccess soa(Thread::Current()); - ArtField* target_field = GetBootImageVarHandleField(invoke); + ArtField* target_field = GetImageVarHandleField(invoke); if (expected_coordinates_count == 0u) { ObjPtr<mirror::Class> declaring_class = target_field->GetDeclaringClass(); if (Runtime::Current()->GetHeap()->ObjectIsInBootImageSpace(declaring_class)) { diff --git a/compiler/optimizing/intrinsics_riscv64.cc b/compiler/optimizing/intrinsics_riscv64.cc index 32816b5f4b..65776236c1 100644 --- a/compiler/optimizing/intrinsics_riscv64.cc +++ b/compiler/optimizing/intrinsics_riscv64.cc @@ -3774,7 +3774,7 @@ static void GenerateVarHandleTarget(HInvoke* invoke, if (expected_coordinates_count <= 1u) { if (VarHandleOptimizations(invoke).GetUseKnownImageVarHandle()) { ScopedObjectAccess soa(Thread::Current()); - ArtField* target_field = GetBootImageVarHandleField(invoke); + ArtField* target_field = GetImageVarHandleField(invoke); if (expected_coordinates_count == 0u) { ObjPtr<mirror::Class> declaring_class = target_field->GetDeclaringClass(); if (Runtime::Current()->GetHeap()->ObjectIsInBootImageSpace(declaring_class)) { diff --git a/compiler/optimizing/intrinsics_utils.h b/compiler/optimizing/intrinsics_utils.h index 6c08cea3f8..c2f32ae708 100644 --- a/compiler/optimizing/intrinsics_utils.h +++ b/compiler/optimizing/intrinsics_utils.h @@ -207,7 +207,7 @@ static inline DataType::Type GetVarHandleExpectedValueType(HInvoke* invoke, } } -static inline ArtField* GetBootImageVarHandleField(HInvoke* invoke) +static inline ArtField* GetImageVarHandleField(HInvoke* invoke) REQUIRES_SHARED(Locks::mutator_lock_) { DCHECK_LE(GetExpectedVarHandleCoordinatesCount(invoke), 1u); DCHECK(VarHandleOptimizations(invoke).GetUseKnownImageVarHandle()); diff --git a/compiler/optimizing/intrinsics_x86_64.cc b/compiler/optimizing/intrinsics_x86_64.cc index fd74f3f44d..18963bf135 100644 --- a/compiler/optimizing/intrinsics_x86_64.cc +++ b/compiler/optimizing/intrinsics_x86_64.cc @@ -4074,7 +4074,7 @@ static void GenerateVarHandleTarget(HInvoke* invoke, if (expected_coordinates_count <= 1u) { if (VarHandleOptimizations(invoke).GetUseKnownImageVarHandle()) { ScopedObjectAccess soa(Thread::Current()); - ArtField* target_field = GetBootImageVarHandleField(invoke); + ArtField* target_field = GetImageVarHandleField(invoke); if (expected_coordinates_count == 0u) { ObjPtr<mirror::Class> declaring_class = target_field->GetDeclaringClass(); __ movl(CpuRegister(target.object), |