summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Stefano Cianciulli <scianciulli@google.com> 2023-06-19 14:25:36 +0000
committer Treehugger Robot <android-test-infra-autosubmit@system.gserviceaccount.com> 2023-06-20 09:12:09 +0000
commit5bf0f68407d3467a3fbfa9ab9ae0c8fabead615b (patch)
tree72235330085c72c9b5f9171e5f88a3fe5bb45c90
parentade1bd81764de3328b37ac25fc72ea3c73271994 (diff)
Update default values for metrics flags to enable reporting from public
devices Bug: 229618060 Test: art/test/run-test 2232-write-metrics-to-log Change-Id: I9535c5d537b6034cb32b338b6e3444d381e7a33c
-rw-r--r--libartbase/base/flags.h19
1 files changed, 10 insertions, 9 deletions
diff --git a/libartbase/base/flags.h b/libartbase/base/flags.h
index 4c38fbaeec..4734a60568 100644
--- a/libartbase/base/flags.h
+++ b/libartbase/base/flags.h
@@ -263,22 +263,23 @@ struct Flags {
// The reporting spec for regular apps. An example of valid value is "S,1,2,4,*".
// See metrics::ReportingPeriodSpec for complete docs.
- Flag<std::string> MetricsReportingSpec{"metrics.reporting-spec", "", FlagType::kDeviceConfig};
+ Flag<std::string> MetricsReportingSpec{
+ "metrics.reporting-spec", "1,5,30,60,600", FlagType::kDeviceConfig};
// The reporting spec for the system server. See MetricsReportingSpec as well.
- Flag<std::string> MetricsReportingSpecSystemServer{"metrics.reporting-spec-server", "",
- FlagType::kDeviceConfig};
+ Flag<std::string> MetricsReportingSpecSystemServer{
+ "metrics.reporting-spec-server", "1,10,60,3600,*", FlagType::kDeviceConfig};
// The mods that should report metrics. Together with MetricsReportingNumMods, they
// dictate what percentage of the runtime execution will report metrics.
// If the `session_id (a random number) % MetricsReportingNumMods < MetricsReportingMods`
// then the runtime session will report metrics.
//
- // By default, the mods are 0, which means the reporting is disabled.
- Flag<uint32_t> MetricsReportingMods{"metrics.reporting-mods", 0,
- FlagType::kDeviceConfig};
- Flag<uint32_t> MetricsReportingModsServer{"metrics.reporting-mods-server", 0,
- FlagType::kDeviceConfig};
+ // By default, the mods are 2, which means that 2 out of #{reporting-num-mods} of Android sessions
+ // will be reported (with the default values this is 2/100 = 2%).
+ Flag<uint32_t> MetricsReportingMods{"metrics.reporting-mods", 2, FlagType::kDeviceConfig};
+ Flag<uint32_t> MetricsReportingModsServer{
+ "metrics.reporting-mods-server", 2, FlagType::kDeviceConfig};
// See MetricsReportingMods docs.
//
@@ -293,7 +294,7 @@ struct Flags {
// Whether or not we should write metrics to statsd.
// Note that the actual write is still controlled by
// MetricsReportingMods and MetricsReportingNumMods.
- Flag<bool> MetricsWriteToStatsd{ "metrics.write-to-statsd", false, FlagType::kDeviceConfig};
+ Flag<bool> MetricsWriteToStatsd{"metrics.write-to-statsd", true, FlagType::kDeviceConfig};
// Whether or not we should write metrics to logcat.
// Note that the actual write is still controlled by