diff options
| author | 2017-02-14 16:16:30 +0000 | |
|---|---|---|
| committer | 2017-02-14 16:16:30 +0000 | |
| commit | 57070daa94f1eb98bea947494b98ac296eebeed6 (patch) | |
| tree | 887b685650ee58c50f8b16bd383416dc408c4392 | |
| parent | 38f5663a970b633f08e144b4dff33633c51352ee (diff) | |
Revert "Enable dex2oat swap test for CC on x86."
Is't still failing and the difference can be
rather huge:
Expected: (native_alloc_2_) < (native_alloc_1_),
actual: 379712 vs 248600
Bug: 29259363
This reverts commit 38f5663a970b633f08e144b4dff33633c51352ee.
Change-Id: Ie1d62fbba688aeadffb9d5aafd5b9cf632742ed6
| -rw-r--r-- | dex2oat/dex2oat_test.cc | 5 | ||||
| -rw-r--r-- | runtime/common_runtime_test.h | 6 |
2 files changed, 11 insertions, 0 deletions
diff --git a/dex2oat/dex2oat_test.cc b/dex2oat/dex2oat_test.cc index e208337652..90b49556b7 100644 --- a/dex2oat/dex2oat_test.cc +++ b/dex2oat/dex2oat_test.cc @@ -399,6 +399,11 @@ class Dex2oatSwapUseTest : public Dex2oatSwapTest { }; TEST_F(Dex2oatSwapUseTest, CheckSwapUsage) { + // The `native_alloc_2_ >= native_alloc_1_` assertion below may not + // hold true on some x86 systems when read barriers are enabled; + // disable this test while we investigate (b/29259363). + TEST_DISABLED_FOR_READ_BARRIER_ON_X86(); + RunTest(false /* use_fd */, false /* expect_use */); GrabResult1(); diff --git a/runtime/common_runtime_test.h b/runtime/common_runtime_test.h index 26ec364285..17e3729a20 100644 --- a/runtime/common_runtime_test.h +++ b/runtime/common_runtime_test.h @@ -223,6 +223,12 @@ class CheckJniAbortCatcher { return; \ } +#define TEST_DISABLED_FOR_READ_BARRIER_ON_X86() \ + if (kUseReadBarrier && kRuntimeISA == kX86) { \ + printf("WARNING: TEST DISABLED FOR READ BARRIER ON X86\n"); \ + return; \ + } + #define TEST_DISABLED_FOR_STRING_COMPRESSION() \ if (mirror::kUseStringCompression) { \ printf("WARNING: TEST DISABLED FOR STRING COMPRESSION\n"); \ |