diff options
| author | 2015-07-21 16:25:44 +0200 | |
|---|---|---|
| committer | 2015-10-21 17:02:53 +0200 | |
| commit | 30486987cf93ef76a725a5761c5153c230e9079e (patch) | |
| tree | e55eb0f6dc2056e81a0a08e875499ad0e151b1bc | |
| parent | 534a9b68ec5e8dda8f6e0a07bf0fdbaeb0cedbfe (diff) | |
Fix art-run-tests dependencies
Their classpath dependency was missing
(cherry picked from commit 6c8d5962573e2df393594bbcee80d07f16edafe3)
Change-Id: Id4f489c140585c62b6c105533b97837612c6199c
| -rw-r--r-- | build/Android.common_path.mk | 6 | ||||
| -rw-r--r-- | test/Android.run-test.mk | 13 | ||||
| -rwxr-xr-x | test/run-test | 13 |
3 files changed, 8 insertions, 24 deletions
diff --git a/build/Android.common_path.mk b/build/Android.common_path.mk index a561c5f4c5..4abd191f54 100644 --- a/build/Android.common_path.mk +++ b/build/Android.common_path.mk @@ -90,6 +90,8 @@ HOST_CORE_DEX_FILES := $(foreach jar,$(HOST_CORE_JARS), $(call intermediates- TARGET_CORE_DEX_FILES := $(foreach jar,$(TARGET_CORE_JARS),$(call intermediates-dir-for,JAVA_LIBRARIES,$(jar), ,COMMON)/javalib.jar) # Classpath for Jack compilation: we only need core-libart. -HOST_JACK_CLASSPATH := $(abspath $(call intermediates-dir-for,JAVA_LIBRARIES,core-libart-hostdex,t,COMMON)/classes.jack) -TARGET_JACK_CLASSPATH := $(abspath $(call intermediates-dir-for,JAVA_LIBRARIES,core-libart, ,COMMON)/classes.jack) +HOST_JACK_CLASSPATH_DEPENDENCIES := $(call intermediates-dir-for,JAVA_LIBRARIES,core-libart-hostdex,t,COMMON)/classes.jack +HOST_JACK_CLASSPATH := $(foreach dep,$(HOST_JACK_CLASSPATH_DEPENDENCIES),$(abspath $(dep))) +TARGET_JACK_CLASSPATH_DEPENDENCIES := $(call intermediates-dir-for,JAVA_LIBRARIES,core-libart, ,COMMON)/classes.jack +TARGET_JACK_CLASSPATH := $(foreach dep,$(TARGET_JACK_CLASSPATH_DEPENDENCIES),$(abspath $(dep))) endif # ART_ANDROID_COMMON_PATH_MK diff --git a/test/Android.run-test.mk b/test/Android.run-test.mk index b83d4a4eeb..9c04135c71 100644 --- a/test/Android.run-test.mk +++ b/test/Android.run-test.mk @@ -41,8 +41,7 @@ TEST_ART_RUN_TEST_DEPENDENCIES := \ ifeq ($(ANDROID_COMPILE_WITH_JACK),true) TEST_ART_RUN_TEST_DEPENDENCIES += \ - $(JACK_JAR) \ - $(JACK_LAUNCHER_JAR) \ + $(JACK) \ $(JILL_JAR) endif @@ -61,15 +60,13 @@ define define-build-art-run-test run_test_options += --build-with-javac-dx endif $$(dmart_target): PRIVATE_RUN_TEST_OPTIONS := $$(run_test_options) -$$(dmart_target): $(TEST_ART_RUN_TEST_DEPENDENCIES) +$$(dmart_target): $(TEST_ART_RUN_TEST_DEPENDENCIES) $(TARGET_JACK_CLASSPATH_DEPENDENCIES) $(hide) rm -rf $$(dir $$@) && mkdir -p $$(dir $$@) $(hide) DX=$(abspath $(DX)) JASMIN=$(abspath $(HOST_OUT_EXECUTABLES)/jasmin) \ SMALI=$(abspath $(HOST_OUT_EXECUTABLES)/smali) \ DXMERGER=$(abspath $(HOST_OUT_EXECUTABLES)/dexmerger) \ JACK=$(abspath $(JACK)) \ - JACK_VM_COMMAND="$(JACK_VM) $(DEFAULT_JACK_VM_ARGS) $(JAVA_TMPDIR_ARG) -jar $(abspath $(JACK_LAUNCHER_JAR)) " \ JACK_CLASSPATH=$(TARGET_JACK_CLASSPATH) \ - JACK_JAR=$(abspath $(JACK_JAR)) \ JILL_JAR=$(abspath $(JILL_JAR)) \ $(LOCAL_PATH)/run-test $$(PRIVATE_RUN_TEST_OPTIONS) --output-path $$(abspath $$(dir $$@)) $(1) $(hide) touch $$@ @@ -695,13 +692,13 @@ define define-test-art-run-test uc_host_or_target := HOST test_groups := ART_RUN_TEST_HOST_RULES run_test_options += --host - prereq_rule := $(ART_TEST_HOST_RUN_TEST_DEPENDENCIES) + prereq_rule := $(ART_TEST_HOST_RUN_TEST_DEPENDENCIES) $(HOST_JACK_CLASSPATH_DEPENDENCIES) jack_classpath := $(HOST_JACK_CLASSPATH) else ifeq ($(1),target) uc_host_or_target := TARGET test_groups := ART_RUN_TEST_TARGET_RULES - prereq_rule := test-art-target-sync + prereq_rule := test-art-target-sync $(TARGET_JACK_CLASSPATH_DEPENDENCIES) jack_classpath := $(TARGET_JACK_CLASSPATH) else $$(error found $(1) expected $(TARGET_TYPES)) @@ -917,9 +914,7 @@ $$(run_test_rule_name): $(TEST_ART_RUN_TEST_DEPENDENCIES) $(HOST_OUT_EXECUTABLES SMALI=$(abspath $(HOST_OUT_EXECUTABLES)/smali) \ DXMERGER=$(abspath $(HOST_OUT_EXECUTABLES)/dexmerger) \ JACK=$(abspath $(JACK)) \ - JACK_VM_COMMAND="$(JACK_VM) $(DEFAULT_JACK_VM_ARGS) $(JAVA_TMPDIR_ARG) -jar $(abspath $(JACK_LAUNCHER_JAR)) " \ JACK_CLASSPATH=$$(PRIVATE_JACK_CLASSPATH) \ - JACK_JAR=$(abspath $(JACK_JAR)) \ JILL_JAR=$(abspath $(JILL_JAR)) \ art/test/run-test $$(PRIVATE_RUN_TEST_OPTIONS) $(12) \ && $$(call ART_TEST_PASSED,$$@) || $$(call ART_TEST_FAILED,$$@) diff --git a/test/run-test b/test/run-test index 1b71f33209..293779f7c3 100755 --- a/test/run-test +++ b/test/run-test @@ -82,24 +82,11 @@ if [ -z "$ANDROID_BUILD_TOP" ]; then export ANDROID_BUILD_TOP=$oldwd fi -# If JACK_VM_COMMAND is not set, assume it launches the prebuilt jack-launcher. -if [ -z "$JACK_VM_COMMAND" ]; then - if [ ! -z "$TMPDIR" ]; then - jack_temp_dir="-Djava.io.tmpdir=$TMPDIR" - fi - export JACK_VM_COMMAND="java -Dfile.encoding=UTF-8 -Xms2560m -XX:+TieredCompilation $jack_temp_dir -jar $ANDROID_BUILD_TOP/prebuilts/sdk/tools/jack-launcher.jar" -fi - # If JACK_CLASSPATH is not set, assume it only contains core-libart. if [ -z "$JACK_CLASSPATH" ]; then export JACK_CLASSPATH="$ANDROID_BUILD_TOP/out/host/common/obj/JAVA_LIBRARIES/core-libart-hostdex_intermediates/classes.jack" fi -# If JACK_JAR is not set, assume it is located in the prebuilts directory. -if [ -z "$JACK_JAR" ]; then - export JACK_JAR="$ANDROID_BUILD_TOP/prebuilts/sdk/tools/jack.jar" -fi - # If JILL_JAR is not set, assume it is located in the prebuilts directory. if [ -z "$JILL_JAR" ]; then export JILL_JAR="$ANDROID_BUILD_TOP/prebuilts/sdk/tools/jill.jar" |