diff options
| author | 2023-11-07 14:44:19 +0000 | |
|---|---|---|
| committer | 2023-11-07 17:13:12 +0000 | |
| commit | 2fdcf22dc6fb24f364008eb612c57582857006a7 (patch) | |
| tree | c081d5f79e098584cfda9d800802073653a25d87 | |
| parent | 9ef4c97403b7ba807effa469897fffdb43fe86d9 (diff) | |
Make it fatal if we cannot initialize private region for jit code cache
We should be able to usually initialize a private region. The rest of
the code assumes that private region has been initialized and that the
code and data mspace have been initialized. If private region couldn't
be initialized we cannot JIT at all. We should be able to initialize
private region always. If we couldn't then it means something else is
not working and we need to fix it. So instead of logging a warning make
it fatal to catch any issues earlier.
Bug: 307441080
Test: art/test.py
Change-Id: I6a090164ffa4b45378400d930a470bbaa56d3535
| -rw-r--r-- | runtime/jit/jit_code_cache.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/runtime/jit/jit_code_cache.cc b/runtime/jit/jit_code_cache.cc index 30703e3eb5..3aaca9acff 100644 --- a/runtime/jit/jit_code_cache.cc +++ b/runtime/jit/jit_code_cache.cc @@ -1978,7 +1978,7 @@ void JitCodeCache::PostForkChildAction(bool is_system_server, bool is_zygote) { /* rwx_memory_allowed= */ !is_system_server, is_zygote, &error_msg)) { - LOG(WARNING) << "Could not create private region after zygote fork: " << error_msg; + LOG(FATAL) << "Could not create private region after zygote fork: " << error_msg; } if (private_region_.HasCodeMapping()) { const MemMap* exec_pages = private_region_.GetExecPages(); |