commit d12031bf2789dc0f9d6aa3e8f31c0f5ba3f983b5
author Adrian Salido <salidoa@google.com> Wed Mar 29 15:58:38 2017 -0700
committer Michael Bestas <mkbestas@lineageos.org> Sun Oct 29 22:13:01 2023 +0000
tree 562e2959557e931b1dfebac86c14189f98ba5874
parent 48bfafcf39bf862883456494bf271595a714ced8

power: Fix power hal compiler warnings

Bug: 30432975
Test: compile power hal for walleye without warnings
Change-Id: I0d90c26462c662690f8a179250000b9a449a109f
Signed-off-by: Arian <arian.kulmer@web.de>

hint-data.c

diff --git a/hint-data.c b/hint-data.c
index b979693..26d2094 100644
--- a/hint-data.c
+++ b/hint-data.c
@@ -27,6 +27,9 @@
  * IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+#define LOG_TAG "QTI PowerHAL"
+#include <log/log.h>
+
 #include "hint-data.h"
 
 int hint_compare(struct hint_data* first_hint, struct hint_data* other_hint) {
@@ -40,5 +43,5 @@
 }
 
 void hint_dump(struct hint_data* hint) {
-    /*ALOGI("hint_id: %lu", hint->hint_id);*/
+    ALOGV("hint_id: %lu", hint->hint_id);
 }

metadata-defs.h

diff --git a/metadata-defs.h b/metadata-defs.h
index 7160af4..bbc5fbf 100644
--- a/metadata-defs.h
+++ b/metadata-defs.h
@@ -46,8 +46,8 @@
     int state;
 };
 
-int parse_metadata(char* metadata, char** metadata_saveptr, char* attribute, int attribute_size,
-                   char* value, int value_size);
+int parse_metadata(char* metadata, char** metadata_saveptr, char* attribute,
+                   unsigned int attribute_size, char* value, unsigned int value_size);
 int parse_video_encode_metadata(char* metadata,
                                 struct video_encode_metadata_t* video_encode_metadata);
 int parse_video_decode_metadata(char* metadata,

metadata-parser.c

diff --git a/metadata-parser.c b/metadata-parser.c
index 30efee8..4a8bc30 100644
--- a/metadata-parser.c
+++ b/metadata-parser.c
@@ -33,8 +33,8 @@
 
 #include "metadata-defs.h"
 
-int parse_metadata(char* metadata, char** metadata_saveptr, char* attribute, int attribute_size,
-                   char* value, int value_size) {
+int parse_metadata(char* metadata, char** metadata_saveptr, char* attribute,
+                   unsigned int attribute_size, char* value, unsigned int value_size) {
     char* attribute_string;
     char* attribute_value_delim;
     unsigned int bytes_to_copy;
@@ -46,15 +46,12 @@
     attribute[0] = value[0] = '\0';
 
     if ((attribute_value_delim = strchr(attribute_string, ATTRIBUTE_VALUE_DELIM)) != NULL) {
-        bytes_to_copy = MIN((attribute_value_delim - attribute_string), attribute_size - 1);
-        /* Replace strncpy with strlcpy
-         * Add +1 to bytes_to_copy as strlcpy copies size-1 bytes */
-        strlcpy(attribute, attribute_string, bytes_to_copy + 1);
+        unsigned int attribute_len = (unsigned int)(attribute_value_delim - attribute_string);
+        /* copy only attribute len + NUL character, or as much as can be fit */
+        bytes_to_copy = MIN(attribute_len + 1, attribute_size);
 
-        bytes_to_copy = MIN(strlen(attribute_string) - strlen(attribute) - 1, value_size - 1);
-        /* Replace strncpy with strlcpy
-         * Add +1 to bytes_to_copy as strlcpy copies size-1 bytes */
-        strlcpy(value, attribute_value_delim + 1, bytes_to_copy + 1);
+        strlcpy(attribute, attribute_string, bytes_to_copy);
+        strlcpy(value, attribute_value_delim + 1, value_size);
     }
 
     return METADATA_PARSING_CONTINUE;