ipacm: Print flt rules that fail mdfy_flt_rule
Move the individual flt rule status check outside the
IOCTl fail check to seperate the rules that failed when
IPACM sends more than one rule.
Change-Id: I4a2c51374bbedced687e23041104a1bc33627c55
Signed-off-by: Michael Adisumarta <madisuma@codeaurora.org>
diff --git a/ipacm/src/IPACM_Filtering.cpp b/ipacm/src/IPACM_Filtering.cpp
index b230c36..875a794 100644
--- a/ipacm/src/IPACM_Filtering.cpp
+++ b/ipacm/src/IPACM_Filtering.cpp
@@ -1006,17 +1006,18 @@
}
ret = ioctl(fd, IPA_IOC_MDFY_FLT_RULE, ruleTable);
+
+ for (i = 0; i < ruleTable->num_rules; i++)
+ {
+ if (ruleTable->rules[i].status != 0)
+ {
+ IPACMERR("Modifying filter rule %d failed\n", i);
+ }
+ }
+
if (ret != 0)
{
- IPACMERR("Failed modifying filtering rule %pK\n", ruleTable);
-
- for (i = 0; i < ruleTable->num_rules; i++)
- {
- if (ruleTable->rules[i].status != 0)
- {
- IPACMERR("Modifying filter rule %d failed\n", i);
- }
- }
+ IPACMERR("Failed modifying filtering rule IOCTL for %pK\n", ruleTable);
return false;
}