commit 8e012d9c7c574cf5cbd4cb47747a23585d3da0e9
author Revanth Rajashekar <quic_rrajashe@quicinc.com> Thu Aug 11 17:56:07 2022 -0700
committer Gerrit - the friendly Code Review server <code-review@localhost> Fri Aug 12 16:57:12 2022 -0700
tree 928ba694d4781fd116924d6758154fd56ffd1dfd
parent 725fb1cde684d5456cc6f6f9c00fa84b64c714e5

agm: Address potential coding issues

Fixed potential NULL pointer dreference.
Initialize the uninitialized variables,
thus preventing the usage of an erroneous value.

Change-Id: I1c4381012a752fa033484309ad9769f635d61e59

plugins/tinyalsa/test/agmcompresscap.c

diff --git a/plugins/tinyalsa/test/agmcompresscap.c b/plugins/tinyalsa/test/agmcompresscap.c
index 08c7061..aad5287 100644
--- a/plugins/tinyalsa/test/agmcompresscap.c
+++ b/plugins/tinyalsa/test/agmcompresscap.c
@@ -471,13 +471,13 @@
 
 int main(int argc, char **argv)
 {
-    char *file;
+    char *file = NULL;
     unsigned long buffer_size = 0;
     unsigned int card = 0, device = 0, frag = 0, length = 0;
     unsigned int rate = DEFAULT_RATE, channels = DEFAULT_CHANNELS;
     unsigned int bits = 16;
     unsigned int format = DEFAULT_FORMAT;
-    char* intf_name;
+    char* intf_name = NULL;
     int ret = 0;
     unsigned int devicepp_kv = DEVICEPP_TX_AUDIO_FLUENCE_SMECNS;
     unsigned int stream_kv = 0;

plugins/tinyalsa/test/agmhostless.c

diff --git a/plugins/tinyalsa/test/agmhostless.c b/plugins/tinyalsa/test/agmhostless.c
index d9228a2..4819725 100644
--- a/plugins/tinyalsa/test/agmhostless.c
+++ b/plugins/tinyalsa/test/agmhostless.c
@@ -219,6 +219,11 @@
     struct group_config grp_config;
     stream_kv = stream_kv ? stream_kv : PCM_RX_LOOPBACK;
 
+    if (!cap_config || !p_config || !capture_intf || !play_intf) {
+        printf("%s: %d: Invalid arguments.\n", __func__, __LINE__);
+        return;
+    }
+
     memset(&config, 0, sizeof(config));
     config.channels = channels;
     config.rate = rate;