commit 29d23134724a7bfcbc5ac6a05d089087c69a7389
author Srinivas Marka <quic_smarka@quicinc.com> Thu Aug 18 14:25:09 2022 +0530
committer Srinivas Marka <quic_smarka@quicinc.com> Tue Aug 01 14:16:20 2023 +0530
tree 46270d8384eedff2d515c6dbf932960a6ab8592e
parent d817f0e259a91acd5da25ab9dbed6fc933b3ecb2

service: metadata: Add check to avoid null pointer dereference

add check to avoid null pointer dereference and
reset num_kvs incase memory allocation failed

Change-Id: I0d691480d95b9dbd899da393f1e82c47a14dcafd

service/src/metadata.c

diff --git a/service/src/metadata.c b/service/src/metadata.c
index bcf0d51..d49ab18 100644
--- a/service/src/metadata.c
+++ b/service/src/metadata.c
@@ -165,6 +165,22 @@
 {
     int i, j;
 
+    if (!meta_data || !ckv) {
+        AGM_LOGE("Invalid params\n");
+        return;
+    }
+
+    if (!(meta_data->ckv.kv)) {
+        AGM_LOGE("metadata->ckv.kv is NULL, num_kvs=%d\n",
+                                    meta_data->ckv.num_kvs);
+        return;
+    }
+    if (!(ckv->kv)) {
+        AGM_LOGE("ckv->kv is NULL, num_kvs=%d\n",
+                                    ckv->num_kvs);
+        return;
+    }
+
     for (i = 0; i < meta_data->ckv.num_kvs; i++) {
         for (j = 0; j < ckv->num_kvs; j++) {
             if (meta_data->ckv.kv[i].key == ckv->kv[j].key) {