| commit | 9b4246dc2d67413080a302fd8885f3f8537379a5 | [log] [tgz] |
|---|---|---|
| author | Tom Cherry <tomcherry@google.com> | Wed Jun 17 11:40:55 2020 -0700 |
| committer | Tom Cherry <tomcherry@google.com> | Wed Jun 17 11:40:55 2020 -0700 |
| tree | e57344e6d39d5e6ec29cc6c3328809d240309207 | |
| parent | 58c7c24765c6ff6dfc216722892f25ca8521c1ec [diff] |
logd: fix various clang-tidy issues In order of severity: 1) Add a CHECK() that a pointer is not nullptr, where the analyzer believes this is possible. 2) Add `final` appropriately to functions called from constructors. 3) Add missing cloexec flags. 4) Add missing `noexcept` and other subtle performance warnings Test: build with clang-tidy Change-Id: Ifd9a1299a51027a47382926b2224748b5750d6cf